-
Notifications
You must be signed in to change notification settings - Fork 39
chore: migrate all Coder modules to Registry repo #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1965655
chore: add module icons
Parkreiner ad58a76
chore: add sample module files
Parkreiner 592e7a5
chore: add VSCode settings
Parkreiner 2317f92
chore: add general module images for Coder
Parkreiner e905d7a
chore: copy over main modules
Parkreiner 24fef19
chore: update .gitignore
Parkreiner 4bbeb50
fix: add missing contributor README files
Parkreiner 25b7225
fix: update path for TS test helpers
Parkreiner 39b524c
chore: add current lint file
Parkreiner bad778e
chore: update more setup files
Parkreiner f7f7b3e
chore: update setup for windows-rdp type-checking
Parkreiner bdc4679
chore: move exoscale images to whizus namespace
Parkreiner 5dec066
chore: update frontmatter image paths
Parkreiner f373279
fix: update frontmatter icons paths
Parkreiner 9b11825
fix: update remaining fm paths
Parkreiner e87dc93
fix: update windows-rpd tsconfig
Parkreiner 8480748
docs: make comment for clear
Parkreiner c3822ea
fix: make sure TF tests run properly
Parkreiner 12e0eab
chore: add registry health check back
Parkreiner 3886b0e
chore: add back other workflow files
Parkreiner 8b26886
fix: standardize naming conventions for Bash files
Parkreiner a778878
fix: update display name for node.js module
Parkreiner 82e4009
fix: remove typo that prevented GH Actions from picking up job
Parkreiner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: update windows-rpd tsconfig
- Loading branch information
commit e87dc93c371e31c5bc2ec071c852498bbbbd39b8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,25 @@ | ||
{ | ||
// Even though this module doesn't contain any TypeScript, it's still | ||
// Even though this Coder module doesn't contain any TypeScript, it's still | ||
// incredibly helpful to include a custom tsconfig file here to ensure that | ||
// the raw, unprocessed JavaScript we send doesn't use features that are too | ||
// modern, to maximize browser compatibility | ||
"extends": ["../../../../tsconfig.json"], | ||
"compilerOptions": { | ||
"target": "ES6", | ||
"module": "ES6" | ||
// Not using ES6, because ES2018 gives some features that make testing a | ||
// little bit easier. That's still a large net that catches most of our | ||
// target audience, though | ||
"target": "ES2018", | ||
|
||
// Have to still use ESNext module for the testing setup; otherwise the | ||
// tests will break from the `import.meta` references. | ||
"module": "ESNext", | ||
|
||
"paths": { | ||
// 2025-04-16 - This seems to be a Bun-specific bug, where extending the | ||
// tsconfig file causes all paths from the base tsconfig file to be | ||
// forgotten. Node and the VSCode IDE recognize the path no problem, but | ||
// without this, the tests will fail. | ||
"~test": ["../../../../test/test.ts"] | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously had a weird franken-tsconfig file for the entire modules repo, because it was using modern modules for the server, but was restricted to an older browser-specific target as far as what features you could use
I remembered that you can chain tsconfig files, though, so I made the root file as modern/server-specific as possible, and then made this ad-hoc file be co-located with the module