8000 fix: ensure Terraform is available for integration tests by Parkreiner · Pull Request #390 · coder/modules · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

fix: ensure Terraform is available for integration tests #390

Merged
merged 9 commits into from
Jan 28, 2025
Merged

fix: ensure Terraform is available for integration tests #390

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
51f5c2b
test: try failing jobs on purpose
Parkreiner Jan 27, 2025
453e38a
test: try inlining the TF script
Parkreiner Jan 27, 2025
36c6bc4
test: verify that Terraform is installed before running tests
Parkreiner Jan 27, 2025
e28138a
test: see if Node is installed
Parkreiner Jan 27, 2025
df53f96
test: ?????????
Parkreiner Jan 27, 2025
2c7745e
chore: clean up code
Parkreiner Jan 27, 2025
40bb407
fix: update CI steps
Parkreiner Jan 27, 2025
6733ae5
docs: add warning about our current Bun setup
Parkreiner Jan 27, 2025
0a4a62d
refactor: rename variable for clarity
Parkreiner Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: add warning about our current Bun setup
  • Loading branch information
@Parkreiner
Parkreiner committed Jan 27, 2025
commit 6733ae50d5f1795b99f134e2ff5f1543afb54d1f
5 changes: 5 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ jobs:
- name: Set up Bun
uses: oven-sh/setup-bun@v2
with:
# We're using the latest version of Bun for now, but it might be worth
# reconsidering. They've pushed breaking changes in patch releases
# that have broken our CI.
# Our PR where issues started to pop up: https://github.com/coder/modules/pull/383
# The Bun PR that broke things: https://github.com/oven-sh/bun/pull/16067
Comment on lines +26 to +30
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to get this added to the file so that there's a paper trail in case Bun's changes suddenly cause CI to break again

bun-version: latest
- name: Install dependencies
run: bun install
Expand Down
Loading
0