8000 feat(jupyterlab): add support for `subdomain=false` by framctr · Pull Request #316 · coder/modules · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

feat(jupyterlab): add support for subdomain=false #316

Merged
merged 20 commits into from
Oct 21, 2024
Merged

feat(jupyterlab): add support for subdomain=false #316

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
aa294c3
Add support for subdomain to main.tf in jupyterlab module
framctr Oct 8, 2024
9476274
Update run.sh in jupyterlab module with subdomain support
framctr Oct 8, 2024
13b60da
Add support for subdomain in jupyterlab module
framctr Oct 8, 2024
69cb0d0
Merge branch 'main' into jupyterlab-subdomain
framctr Oct 8, 2024
e09b7a1
Merge pull request #2 from framctr/jupyterlab-subdomain
framctr Oct 8, 2024
6936e8e
Merge branch 'main' into jupyterlab-subdomain-1
framctr Oct 8, 2024
92a898e
Merge pull request #1 from framctr/jupyterlab-subdomain-1
framctr Oct 8, 2024
acbf564
Fixes to Subpath on Jupyter module #313
framctr Oct 8, 2024
c7a3834
Merge branch 'main' into main
matifali Oct 15, 2024
e21a5bc
Update jupyterlab/main.tf
matifali Oct 15, 2024
e42b57c
Update main.tf
matifali Oct 15, 2024
d152fb5
Update jupyterlab/main.tf
matifali Oct 15, 2024
329f9eb
bun:fmt
matifali Oct 15, 2024
66dd290
Merge branch 'main' into main
matifali Oct 15, 2024
e960fdc
bump version
matifali Oct 15, 2024
c5c569e
Update jupyterlab/main.tf
matifali Oct 21, 2024
0dcba9b
Update jupyterlab/main.tf
matifali Oct 21, 2024
3d18984
rename FLAG
matifali Oct 21, 2024
3b8b563
Merge branch 'main' into main
matifali Oct 21, 2024
8fc7ed5
Update README.md
matifali Oct 21, 2024
File filter

Filter by e 8000 xtension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions jupyterlab/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,9 @@ variable "share" {
}

variable "subdomain" {
type = bool
default = true
validation {
condition = var.share == "owner" || var.share == "authenticated" || var.share == "public"
error_message = "Incorrect value. Please set either 'owner', 'authenticated', or 'public'."
}
type = bool
description = "Determines whether JupyterLab will be accessed via it's own subdomain or whether it will be accessed via a path on Coder."
default 10000 = true
}

variable "order" {
Expand Down Expand Up @@ -84,4 +81,3 @@ resource "coder_app" "jupyterlab" {
threshold = 10
}
}
}
17 changes: 14 additions & 3 deletions jupyterlab/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/usr/bin/env sh

if [ -n "$BASE_URL" ]
then
BASE_URL="--ServerApp.base_url=${BASE_URL}"
fi

BOLD='\033[0;1m'

printf "$${BOLD}Installing jupyterlab!\n"
Expand All @@ -15,11 +20,17 @@ if ! command -v jupyterlab > /dev/null 2>&1; then
fi
# install jupyterlab
pipx install -q jupyterlab
echo "🥳 jupyterlab has been installed\n\n"
printf "%s\n\n" "🥳 jupyterlab has been installed"
else
echo "🥳 jupyterlab is already installed\n\n"
printf "%s\n\n" "🥳 jupyterlab is already installed"
fi

echo "👷 Starting jupyterlab in background..."
echo "check logs at ${LOG_PATH}"
$HOME/.local/bin/jupyter-lab --ServerApp.ip='0.0.0.0' --ServerApp.port=${PORT} --no-browser --ServerApp.token='' --ServerApp.password='' > ${LOG_PATH} 2>&1 &
$HOME/.local/bin/jupyter-lab --no-browser \
"$BASE_URL" \
--ServerApp.ip='*' \
--ServerApp.port="${PORT}" \
--ServerApp.token='' \
--ServerApp.password='' \
> "${LOG_PATH}" 2>&1 &
0