8000 feat(dotfiles): Add an optional coder_app to update dotfiles on-demand by matifali · Pull Request #280 · coder/modules · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

feat(dotfiles): Add an optional coder_app to update dotfiles on-demand #280

Merged
merged 7 commits into from
Sep 20, 2024
Merged

feat(dotfiles): Add an optional coder_app to update dotfiles on-demand #280

merged 7 commits into from
Sep 20, 2024

Conversation

matifali
Copy link
Member
@matifali matifali commented Aug 13, 2024 •
edited
Loading

Adds an optional coder_app, that lets a user update dotfiles without a workspace restart.

To test use

module "dotfiles" {
  source        = "git::https://github.com/coder/modules.git//dotfiles?ref=matifali/update-dotfiles"
  agent_id      = coder_agent.dev.id
  manual_update = true
}

This adds a button to update dotfiles on demand.
image

@matifali matifali marked this pull request as ready for review August 13, 2024 20:29
@matifali matifali changed the title feat(dotfiles): Add an optional coder app to update dotfiles on-demand feat(dotfiles): Add an optional coder_app to update dotfiles on-demand Aug 13, 2024
@matifali matifali requested a review from kylecarbs August 13, 2024 20:32
cirego
cirego reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor
@cirego cirego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

What do you think about calling it refresh or resync instead of update?

matifali and others added 2 commits August 14, 2024 09:59
@matifali @cirego
Update dotfiles/main.tf
5f743d4 
Co-authored-by: Chris Golden <551285+cirego@users.noreply.github.com>
@matifali
Update --> Refresh
94bfa31
@matifali matifali requested a review from bcpeinhardt August 14, 2024 07:00
@matifali matifali requested review from phorcys420 and stirby and removed request for kylecarbs September 16, 2024 18:07
Parkreiner
Parkreiner reviewed Sep 19, 2024
View reviewed changes
@matifali @Parkreiner
Update dotfiles/main.tf
b18bab5 
Co-authored-by: Michael Smith <throwawayclover@gmail.com>
@matifali matifali merged commit b51932d into main Sep 20, 2024
2 checks passed
@matifali matifali deleted the matifali/update-dotfiles branch September 20, 2024 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cirego cirego cirego left review comments

@Parkreiner Parkreiner Parkreiner left review comments

@bcpeinhardt bcpeinhardt bcpeinhardt approved these changes

@phorcys420 phorcys420 Awaiting requested review from phorcys420

@stirby stirby Awaiting requested review from stirby

@EdwardAngert EdwardAngert Awaiting requested review from EdwardAngert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matifali @cirego @Parkreiner @bcpeinhardt
0