8000 ci: add `update-appcast` script by ethanndickson · Pull Request #171 · coder/coder-desktop-macos · GitHub
[go: up one dir, main page]
Skip to content

ci: add update-appcast script #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

ci: add update-appcast script #171

merged 6 commits into from
May 30, 2025

Conversation

ethanndickson
Copy link
Member
@ethanndickson ethanndickson commented May 28, 2025 •
edited
Loading

Third PR for #47.

Adds a script to update an existing appcast.xml.

This will be called in CI to update the appcast before uploading it back to our feed URL (releases.coder.com/...). It's currently not used anywhere.

Invoked like:

swift run update-appcast -i appcast.xml -s CoderDesktop.pkg.sig -v 0.5.1 -o appcast.xml -d ${{ github.event.release.body }}

To update an appcast that looks like:

appcast.xml 
<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<rss xmlns:sparkle="http://www.andymatuschak.org/xml-namespaces/sparkle" version="2.0">
    <channel>
        <title>Coder Desktop</title>
        <item>
            <title>v0.5.1</title>
            <description><![CDATA[<h2>What's Changed</h2>
<ul>
<li>fix: don't create http client if signed out by @ethanndickson in <a href="https://github.com/coder/coder-deskt%E2%80%A6r-desktop-macos/pull/170">https://github.com/coder/coder-deskt…r-desktop-macos/pull/170</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/coder/coder-desktop-macos/compare/v0.5.0...v0.5.1">https://github.com/coder/coder-desktop-macos/compare/v0.5.0...v0.5.1</a></p>]]></description>
            <pubDate>Thu, 29 May 2025 06:08:56 +0000</pubDate>
            <sparkle:channel>stable</sparkle:channel>
            <sparkle:version>0.5.1</sparkle:version>
            <sparkle:fullReleaseNotesLink>https://github.com/coder/coder-desktop-macos/releases</sparkle:fullReleaseNotesLink>
            <sparkle:minimumSystemVersion>14.0.0</sparkle:minimumSystemVersion>
            <enclosure url="https://github.com/coder/coder-desktop-macos/releases/download/v0.5.1/Coder-Desktop.pkg" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="NkyCj7Lzpw95P0N95SQHiBCjDLZYVukbRR3aOjGZAuL5Dc+I//DfTCRFCxoQNhA38uu/CCAR8v9E4SgMkDdmAA==" length="39630183"></enclosure>
        </item>
        <item>
            <title>Preview</title>
            <pubDate>Thu, 29 May 2025 06:08:08 +0000</pubDate>
            <sparkle:channel>preview</sparkle:channel>
            <sparkle:version>0.5.0.3</sparkle:version>
            <sparkle:fullReleaseNotesLink>https://github.com/coder/coder-desktop-macos/releases</sparkle:fullReleaseNotesLink>
            <sparkle:minimumSystemVersion>14.0.0</sparkle:minimumSystemVersion>
            <enclosure url="https://github.com/coder/coder-desktop-macos/releases/download/preview/Coder-Desktop.pkg" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="L0cFeyoy+D/Zgm3eXok87SKmgIUka8m2b+g7UWPReF4UhFUb4RlDsZ5PxXKd5MrtsaODGUz2iRMWraO7aQg+DA==" length="39630898"></enclosure>
        </item>
    </channel>
</rss>

Producing a notification like:

image

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson force-pushed the ethan/update-appcast-script branch from d4fc465 to 0a75509 Compare May 28, 2025 11:15
@ethanndickson ethanndickson requested a review from Copilot May 28, 2025 11:17
@ethanndickson ethanndickson changed the title ci: add update-appcast script ci: add update-appcast script May 28, 2025
Copilot
Copilot AI reviewed May 28, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new Swift CLI tool to update a Sparkle appcast XML with a fresh <item> entry using provided version and signature.

  • Introduces update-appcast script for automating appcast updates.
  • Defines its Swift package and tailored SwiftLint configuration.
  • Updates global SwiftLint settings to ignore the build directory.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

File Description
scripts/update-appcast/Sources/main.swift Implements the appcast update logic and XML edits
scripts/update-appcast/Package.swift Declares the Swift package and its dependencies
scripts/update-appcast/.swiftlint.yml Disables todo and trailing_comma rules
.swiftlint.yml Excludes the .build/ directory from lint checks

@ethanndickson ethanndickson marked this pull request as ready for review May 28, 2025 11:22
@ethanndickson Graphite App
Copy link
Member Author
ethanndickson commented May 30, 2025 •
edited
Loading

Merge activity

  • May 30, 2:27 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 30, 2:27 AM UTC: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit 96da5ae into main May 30, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/update-appcast-script branch May 30, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @deansheather
0