8000 chore(coderd/util/tz): skip flaky test under windows by johnstcn · Pull Request #8652 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore(coderd/util/tz): skip flaky test under windows #8652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023
Merged

chore(coderd/util/tz): skip flaky test under windows #8652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions coderd/util/tz/tz_test.go
View file
Open in desktop
4290
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ func Test_TimezoneIANA(t *testing.T) {
// Not all Linux operating systems are guaranteed to have localtime!
t.Skip("localtime doesn't exist!")
}
if runtime.GOOS == "windows" {
// This test can be flaky on some Windows runners :(
t.Skip("This test is flaky under Windows.")
}
oldEnv, found := os.LookupEnv("TZ")
if found {
require.NoError(t, os.Unsetenv("TZ"))
Expand Down
0