8000 fix: use numeric comparison to check monotonicity by mtojek · Pull Request #8436 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: use numeric comparison to check monotonicity #8436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: use numeric comparison to check monotonicity #8436

merged 1 commit into from
Jul 11, 2023

Conversation

mtojek
Copy link
Member
@mtojek mtojek commented Jul 11, 2023

This PR fixes the monotonicity validation of coder parameters.

The function ValidateWorkspaceBuildParameters should perform a numeric comparison of values instead of a lexical one.

@mtojek mtojek self-assigned this Jul 11, 2023
@mtojek mtojek requested a review from kylecarbs July 11, 2023 19:47
@mtojek mtojek marked this pull request as ready for review July 11, 2023 19:47
@mtojek mtojek merged commit bc835db into main Jul 11, 2023
@mtojek mtojek deleted the fix-monotonic-lex branch July 11, 2023 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @kylecarbs
0