8000 chore: use a cache to select best latency by Emyrk · Pull Request #7879 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: use a cache to select best latency #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2023
Merged

chore: use a cache to select best latency #7879

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b909e82
chore: Testing using a cache to choose the best latency
Emyrk Jun 6, 2023
84bc00f
Allow storing more latencies if needed
Emyrk Jun 6, 2023
1ab0758
Make fmt
Emyrk Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow storing more latencies if needed
  • Loading branch information
@Emyrk
Emyrk committed Jun 6, 2023
commit 84bc00fa5ddb382a8f5c817bb025deda43abadd8
21 changes: 15 additions & 6 deletions site/src/contexts/useProxyLatency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,16 @@ export const useProxyLatency = (
refetch: () => void
proxyLatencies: Record<string, ProxyLatencyReport>
} => {
// maxStoredLatencies is the maximum number of latencies to store per proxy in local storage.
let maxStoredLatencies = 5
// The reason we pull this from local storage is so for development purposes, a user can manually
// set a larger number to collect data in their normal usage. This data can later be analyzed to come up
// with some better magic numbers.
const maxStoredLatenciesVar = localStorage.getItem("workspace-proxy-latencies-max")
if(maxStoredLatenciesVar) {
maxStoredLatencies = Number(maxStoredLatenciesVar)
}

const [proxyLatencies, dispatchProxyLatencies] = useReducer(
proxyLatenciesReducer,
{},
Expand Down Expand Up @@ -188,7 +198,7 @@ export const useProxyLatency = (
observer.disconnect()

// Local storage cleanup
garbageCollectStoredLatencies(proxies)
garbageCollectStoredLatencies(proxies, maxStoredLatencies)
})
}, [proxies, latestFetchRequest])

Expand Down Expand Up @@ -224,16 +234,15 @@ const updateStoredLatencies =(action: ProxyLatencyAction): void => {

// garbageCollectStoredLatencies will remove any latencies that are older then 1 week or latencies of proxies
// that no longer exist. This is intended to keep the size of local storage down.
const garbageCollectStoredLatencies = (regions: RegionsResponse): void => {
const garbageCollectStoredLatencies = (regions: RegionsResponse, maxStored: number): void => {
const latencies = loadStoredLatencies()
const now = Date.now()
console.log("Garbage collecting stored latencies")
const cleaned = cleanupLatencies(latencies, regions, new Date(now))
const cleaned = cleanupLatencies(latencies, regions, new Date(now), maxStored)

localStorage.setItem("workspace-proxy-latencies", JSON.stringify(cleaned))
}

const cleanupLatencies = (stored: Record<string, ProxyLatencyReport[]>, regions: RegionsResponse, now: Date): Record<string, ProxyLatencyReport[]> => {
const cleanupLatencies = (stored: Record<string, ProxyLatencyReport[]>, regions: RegionsResponse, now: Date, maxStored: number): Record<string, ProxyLatencyReport[]> => {
Object.keys(stored).forEach((proxyID) => {
if(!regions.regions.find((region) => region.id === proxyID)) {
delete(stored[proxyID])
Expand All @@ -246,7 +255,7 @@ const cleanupLatencies = (stored: Record<string, ProxyLatencyReport[]>, regions:
return new Date(report.at).getTime() > nowMS - (1000 * 60 * 60 * 24 * 7)
})
// Only keep the 5 latest
stored[proxyID] = stored[proxyID].slice(-5)
stored[proxyID] = stored[proxyID].slice(-1*maxStored)
})
return stored
}
Expand Down
0