8000 feat: sort users by username by mtojek · Pull Request #7838 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: sort users by username #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2023
Merged

feat: sort users by username #7838

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1358d81
feat: sort users by username
mtojek Jun 5, 2023
b2e45d8
fix
mtojek Jun 5, 2023
8bf7d54
possible fix
mtojek Jun 5, 2023
97e52c8
Address PR comments
mtojek Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
possible fix
  • Loading branch information
@mtojek
mtojek committed Jun 5, 2023
commit 8bf7d54a6a3c8822b9f10c11e064d1b6b52bfba0
6 changes: 3 additions & 3 deletions coderd/database/queries.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions coderd/database/queries/users.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ WHERE
-- duplicating or missing data.
WHEN @after_id :: uuid != '00000000-0000-0000-0000-000000000000'::uuid THEN (
-- The pagination cursor is the last ID of the previous page.
-- The query is ordered by the created_at field, so select all
-- The query is ordered by the username field, so select all
-- rows after the cursor.
(created_at, id) > (
(username) > (
SELECT
created_at, id
username
FROM
users
WHERE
Expand Down
0