8000 fix: use minDisabled, maxDisabled for parameter validation by mtojek · Pull Request #7797 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

fix: use minDisabled, maxDisabled for parameter validation #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unit tests done
  • Loading branch information
mtojek committed Jun 1, 2023
commit 6d24ad68ad3305a22aa03868e76c9392f6c6bea4
41 changes: 41 additions & 0 deletions provisioner/terraform/resources_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,47 @@ func TestConvertResources(t *testing.T) {
ValidationMax: nil,
}},
},
"rich-parameters-validation": {
resources: []*proto.Resource{{
Name: "dev",
Type: "null_resource",
Agents: []*proto.Agent{{
Name: "dev",
OperatingSystem: "windows",
ShutdownScriptTimeoutSeconds: 300,
StartupScriptTimeoutSeconds: 300,
Architecture: "arm64",
Auth: &proto.Agent_Token{},
LoginBeforeReady: true,
ConnectionTimeoutSeconds: 120,
}},
}},
parameters: []*proto.RichParameter{{
Name: "number_example_min_max",
Type: "number",
DefaultValue: "4",
ValidationMin: terraform.PtrInt32(3),
ValidationMax: terraform.PtrInt32(6),
}, {
Name: "number_example_min",
Type: "number",
DefaultValue: "4",
ValidationMin: terraform.PtrInt32(3),
ValidationMax: nil,
}, {
Name: "number_example_max",
Type: "number",
DefaultValue: "4",
ValidationMin: nil,
ValidationMax: terraform.PtrInt32(6),
}, {
Name: "number_example",
Type: "number",
DefaultValue: "4",
ValidationMin: nil,
ValidationMax: nil,
}},
},
"git-auth-providers": {
resources: []*proto.Resource{{
Name: "dev",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
terraform {
required_providers {
coder = {
source = "coder/coder"
version = "0.8.2"
}
}
}

data "coder_parameter" "number_example_min_max" {
name = "number_example_min_max"
type = "number"
default = 4
validation {
min = 3
max = 6
}
}

data "coder_parameter" "number_example_min" {
name = "number_example_min"
type = "number"
default = 4
validation {
min = 3
}
}

data "coder_parameter" "number_example_max" {
name = "number_example_max"
type = "number"
default = 4
validation {
max = 6
}
}

data "coder_parameter" "number_example" {
name = "number_example"
type = "number"
default = 4
}

resource "coder_agent" "dev" {
os = "windows"
arch = "arm64"
}

resource "null_resource" "dev" {
depends_on = [coder_agent.dev]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
0