8000 refactor(site): Show immutable parameters in the settings by BrunoQuaresma · Pull Request #7383 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

refactor(site): Show immutable parameters in the settings #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 3, 2023
Merged

refactor(site): Show immutable parameters in the settings #7383

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75f1eba
Add parameters page
BrunoQuaresma May 2, 2023
856a475
Refactor settings to remove parameters
BrunoQuaresma May 2, 2023
5b9823e
Refactor tests
BrunoQuaresma May 2, 2023
747a9a8
Refactor stories
BrunoQuaresma May 2, 2023
75e1119
Fix form
BrunoQuaresma May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix form
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 2, 2023
commit 75e11198a4c3ccd523afb7a453e8f9e1a6342552
3 changes: 1 addition & 2 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersForm.tsx
View file
Open in desktop 8B24
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
workspaceBuildParameterValue,
} from "utils/richParameters"
import * as Yup from "yup"
import { nameValidator, getFormHelpers } from "utils/formUtils"
import { getFormHelpers } from "utils/formUtils"
import {
TemplateVersionParameter,
WorkspaceBuildParameter,
Expand Down Expand Up @@ -62,7 +62,6 @@ export const WorkspaceParametersForm: FC<{
}),
},
validationSchema: Yup.object({
name: nameValidator(t("nameLabel")),
rich_parameter_values: useValidationSchemaForRichParameters(
"createWorkspacePage",
templateVersionRichParameters,
Expand Down
0