8000 fix: extend regex for template version name by mtojek · Pull Request #6876 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: extend regex for template version name #6876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: extend regex for template version name #6876

merged 1 commit into from
Mar 30, 2023

Conversation

mtojek
Copy link
Member
@mtojek mtojek commented Mar 30, 2023

Fixes: #6857

This PR extends the regexp for the template version name validator making it a bit more permissive.

Allowed names:

heuristic_cray2
v1.0.0
foo-bar

@mtojek mtojek self-assigned this Mar 30, 2023
@mtojek mtojek marked this pull request as ready for review March 30, 2023 10:28
@mtojek mtojek requested review from BrunoQuaresma and bpmct March 30, 2023 10:28
BrunoQuaresma
BrunoQuaresma approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator
@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek merged commit b120247 into coder:main Mar 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[experiments] Cannot publish new version using web UI
2 participants
@mtojek @BrunoQuaresma
0