8000 fix: truly allow overridding default string array by ammario · Pull Request #6874 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: truly allow overridding default string array #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: truly allow overridding default string array #6874

merged 3 commits into from
Mar 31, 2023

Conversation

ammario
Copy link
Member
@ammario ammario commented Mar 30, 2023

#6873 introduced a bug which I reverted here.

This is the same PR but with the bug fix and an additional test.

@ammario ammario requested a review from kylecarbs March 30, 2023 02:21
@ammario ammario enabled auto-merge (squash) March 30, 2023 02:22
@ammario ammario disabled auto-merge March 30, 2023 22:48
@ammario
Copy link
Member Author
ammario commented Mar 30, 2023

@kylecarbs you should look at e5c262e before we merge this. I'm not sure how much people relied on the behavior of flags replacing defaults.

@ammario ammario merged commit 599699b into main Mar 31, 2023
@ammario ammario deleted the cli-defaults branch March 31, 2023 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammario @kylecarbs
0