8000 feat: Enable workspace debug logging by mtojek · Pull Request #6838 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat: Enable workspace debug logging #6838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 30, 2023
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
mtojek committed Mar 28, 2023
commit 1283b7cfa15bc4c29e36f64d4951bd6ef5695082
2 changes: 1 addition & 1 deletion codersdk/workspaces.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ type CreateWorkspaceBuildRequest struct {
ParameterValues []CreateParameterRequest `json:"parameter_values,omitempty"`
RichParameterValues []WorkspaceBuildParameter `json:"rich_parameter_values,omitempty"`

LogLevel ProvisionerLogLevel `json:"log_level" validate:"oneof=debug"`
LogLevel ProvisionerLogLevel `json:"log_level,omitempty" validate:"omitempty,oneof=debug"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Add a comment so this gets documented in the API doc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

}

type WorkspaceOptions struct {
Expand Down
4 changes: 2 additions & 2 deletions provisionerd/proto/provisionerd.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion provisionerd/proto/provisionerd_drpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions provisionersdk/proto/provisioner.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion provisionersdk/proto/provisioner.proto
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ message Provision {
bytes state = 2;
Metadata metadata = 3;

string provisioner_log_level = 4;
string provisioner_log_level = 4;
}

message Plan {
Expand Down
2 changes: 1 addition & 1 deletion site/src/api/typesGenerated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export interface CreateWorkspaceBuildRequest {
readonly orphan?: boolean
readonly parameter_values?: CreateParameterRequest[]
readonly rich_parameter_values?: WorkspaceBuildParameter[]
readonly log_level: ProvisionerLogLevel
readonly log_level?: ProvisionerLogLevel
}

// From codersdk/organizations.go
Expand Down
0