8000 fix: send auto start/stop api calls only when changed by presleyp · Pull Request #5184 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

fix: send auto start/stop api calls only when changed #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

presleyp
Copy link
Contributor

Fixes #5149 - autostart could not be disabled, and now it can.

Also removes some duplicate auto-stop audit log entries, in the spirit of #4513. However audit logging of auto-stop is still not totally correct - in testing this I found #5183.

@presleyp presleyp requested a review from a team as a code owner November 28, 2022 22:37
@presleyp presleyp requested review from BrunoQuaresma and Kira-Pilot and removed request for a team and BrunoQuaresma November 28, 2022 22:37
await API.putWorkspaceAutostart(context.workspace.id, event.autoStart)
}
await API.putWorkspaceAutostop(context.workspace.id, event.ttl)
if (event.autoStopChanged) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we write a test for this?

Copy link
Member
@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, and noted about the Audit Log bug!

@presleyp presleyp merged commit 2e3db27 into main Nov 29, 2022
@presleyp presleyp deleted the disable-autostart/5149/presleyp branch November 29, 2022 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduling: Disabling auto-start does not work
2 participants
0