fix: send auto start/stop api calls only when changed #5184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Nov 29, 2022
| await API.putWorkspaceAutostart(context.workspace.id, event.autoStart) | ||
| } | ||
| await API.putWorkspaceAutostop(context.workspace.id, event.ttl) | ||
| if (event.autoStopChanged) { |
There was a problem hiding this comment.
Nice! Should we write a test for this?
Kira-Pilot
approved these changes
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5149 - autostart could not be disabled, and now it can.
Also removes some duplicate auto-stop audit log entries, in the spirit of #4513. However audit logging of auto-stop is still not totally correct - in testing this I found #5183.