8000 feat: add count to get users endpoint by f0ssel · Pull Request #5016 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add count to get users endpoint #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 14, 2022
Merged

feat: add count to get users endpoint #5016

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f771959
feat: add count to queries in window function
f0ssel Nov 10, 2022
ed5a147
make initial tests pass
f0ssel Nov 14, 2022
5da633e
fix more tests
f0ssel Nov 14, 2022
8a00932
idk
f0ssel Nov 14, 2022
206381d
get presleys help
f0ssel Nov 14, 2022
a1b7e4e
rename test
f0ssel Nov 14, 2022
482b59f
remove count endpoint
f0ssel Nov 14, 2022
0d738e8
remove more
f0ssel Nov 14, 2022
d5b5000
fmt
f0ssel Nov 14, 2022
ada3995
fix js tests
f0ssel Nov 14, 2022
bd34b05
keep fixing
f0ssel Nov 14, 2022
6249824
fmt
f0ssel Nov 14, 2022
8a92b2b
fmt
f0ssel Nov 14, 2022
ef32b99
fix all js tests
f0ssel Nov 14, 2022
7f43a6c
fix
f0ssel Nov 14, 2022
991b518
move states
f0ssel Nov 14, 2022
b86e0cb
fmt
f0ssel Nov 14, 2022
File filter

Filter by extension

8000
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename test
  • Loading branch information
@f0ssel
f0ssel committed Nov 14, 2022
commit a1b7e4edb16afd69be78000057f6896248ae0ccb
89 changes: 43 additions & 46 deletions coderd/users_test.go
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -1307,61 +1307,58 @@ func TestGetFilteredUserCount(t *testing.T) {
})
}

func TestNewGetUsers(t *testing.T) {
func TestGetUsersPagination(t *testing.T) {
t.Parallel()
t.Run("Pagination", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
first := coderdtest.CreateFirstUser(t, client)
client := coderdtest.New(t, nil)
first := coderdtest.CreateFirstUser(t, client)

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()

_, err := client.User(ctx, first.UserID.String())
require.NoError(t, err, "")
_, err := client.User(ctx, first.UserID.String())
require.NoError(t, err, "")

_, err = client.CreateUser(ctx, codersdk.CreateUserRequest{
Email: "alice@email.com",
Username: "alice",
Password: "password",
OrganizationID: first.OrganizationID,
})
require.NoError(t, err)
_, err = client.CreateUser(ctx, codersdk.CreateUserRequest{
Email: "alice@email.com",
Username: "alice",
Password: "password",
OrganizationID: first.OrganizationID,
})
require.NoError(t, err)

res, err := client.Users(ctx, codersdk.UsersRequest{})
require.NoError(t, err)
require.Len(t, res.Users, 2)
require.Equal(t, res.Count, 2)
res, err := client.Users(ctx, codersdk.UsersRequest{})
require.NoError(t, err)
require.Len(t, res.Users, 2)
require.Equal(t, res.Count, 2)

res, err = client.Users(ctx, codersdk.UsersRequest{
Pagination: codersdk.Pagination{
Limit: 1,
},
})
require.NoError(t, err)
require.Len(t, res.Users, 1)
require.Equal(t, res.Count, 2)
res, err = client.Users(ctx, codersdk.UsersRequest{
Pagination: codersdk.Pagination{
Limit: 1,
},
})
require.NoError(t, err)
require.Len(t, res.Users, 1)
require.Equal(t, res.Count, 2)

res, err = client.Users(ctx, codersdk.UsersRequest{
Pagination: codersdk.Pagination{
Offset: 1,
},
})
require.NoError(t, err)
require.Len(t, res.Users, 1)
require.Equal(t, res.Count, 2)
res, err = client.Users(ctx, codersdk.UsersRequest{
Pagination: codersdk.Pagination{
Offset: 1,
},
})
require.NoError(t, err)
require.Len(t, res.Users, 1)
require.Equal(t, res.Count, 2)

// if offset is higher than the count postgres returns an empty array
// and not an ErrNoRows error. This also means the count must be 0.
res, err = client.Users(ctx, codersdk.UsersRequest{
Pagination: codersdk.Pagination{
Offset: 3,
},
})
require.NoError(t, err)
require.Len(t, res.Users, 0)
require.Equal(t, res.Count, 0)
// if offset is higher than the count postgres returns an empty array
// and not an ErrNoRows error. This also means the count must be 0.
res, err = client.Users(ctx, codersdk.UsersRequest{
Pagination: codersdk.Pagination{
Offset: 3,
},
})
require.NoError(t, err)
require.Len(t, res.Users, 0)
require.Equal(t, res.Count, 0)
}

func TestPostTokens(t *testing.T) {
Expand Down
0