8000 feat: make trace provider in loadtest, add tracing to sdk by deansheather · Pull Request #4939 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: make trace provider in loadtest, add tracing to sdk #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2022
Merged

feat: make trace provider in loadtest, add tracing to sdk #4939

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd9425f
feat: make trace provider in loadtest, add tracing to sdk
deansheather Nov 7, 2022
aa79025
fixup! feat: make trace provider in loadtest, add tracing to sdk
deansheather Nov 8, 2022
c31e923
fixup! feat: make trace provider in loadtest, add tracing to sdk
deansheather Nov 8, 2022
4eea6ee
fixup! feat: make trace provider in loadtest, add tracing to sdk
deansheather Nov 8, 2022
8972791
feat: trace fixes, better trace wrapping for loadtests
deansheather Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! feat: make trace provider in loadtest, add tracing to sdk
  • Loading branch information
@deansheather
deansheather committed Nov 8, 2022
commit 4eea6ee98b7b2e98e348bad91661cab6cdd69161
2 changes: 1 addition & 1 deletion agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,8 +617,8 @@ func setupSSHCommand(t *testing.T, beforeArgs []string, afterArgs []string) *exe
}

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()
ssh, err := agentConn.SSH(ctx)
cancel()
if err != nil {
_ = conn.Close()
return
Expand Down
2 changes: 1 addition & 1 deletion cli/configssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ func TestConfigSSH(t *testing.T) {
break
}
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()
ssh, err := agentConn.SSH(ctx)
cancel()
assert.NoError(t, err)
wg.Add(2)
go func() {
Expand Down
0