feat: allow suffix after wildcard in wildcard access URL #4524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Oct 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
--wildcard-access-urlto be set to values like*-apps.coder.example.com. This is support in Coder v1 (and depended on by a large customer), and has been requested in v2 also. This enables using a single SAN to serve both coder and app URLs by issuing a single wildcard cert./applications/hostendpoint now returns the full app hostname as specified by the admin including the*.or*-suffix.prefix. The new preferred way of forming an app URL is to do`${scheme}//${host}`.replace("*", subdomain)TODO: