8000 coder licenses add CLI command by spikecurtis · Pull Request #3632 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

coder licenses add CLI command #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 23, 2022
Merged

coder licenses add CLI command #3632

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2580a17
coder licenses add CLI command
spikecurtis Aug 19, 2022
26309c4
Fix up lint
spikecurtis Aug 22, 2022
09403d3
Fix t.parallel call
spikecurtis Aug 22, 2022
a886c31
Code review improvements
spikecurtis Aug 23, 2022
9c399dd
Lint
spikecurtis Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix t.parallel call 
Signed-off-by: Spike Curtis <spike@coder.com>
  • Loading branch information
@spikecurtis
spikecurtis committed Aug 22, 2022
commit 09403d30bd107c212b3810f020c4f9a155068262
3 changes: 2 additions & 1 deletion enterprise/cli/licenses_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ import (
const fakeLicenseJWT = "test.jwt.sig"

func TestLicensesAddSuccess(t *testing.T) {
t.Parallel()
// We can't check a real license into the git repo, and can't patch out the keys from here,
// so instead we have to fake the HTTP interaction. t.Parallel()
// so instead we have to fake the HTTP interaction.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that we can test licenses for real (in CI) should we consider adding a secret in GitHub actions and only test it in CI (or when defined locally?).

I'm not sure how it would work, just throwing it out there.

Copy link
Contributor Author
@spikecurtis spikecurtis Aug 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if we want to build e2e tests, we'll need real licenses that we don't check into the repo

t.Run("LFlag", func(t *testing.T) {
t.Parallel()
cmd := setupFakeLicenseServerTest(t, "licenses", "add", "-l", fakeLicenseJWT)
Expand Down
0