8000 fix: Disallow args for config-ssh subcommand in cli by mafredri · Pull Request #3393 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: Disallow args for config-ssh subcommand in cli #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2022
Merged

fix: Disallow args for config-ssh subcommand in cli #3393

merged 1 commit into from
Aug 6, 2022

Conversation

mafredri
Copy link
Member
@mafredri mafredri commented Aug 6, 2022

Args are not used in coder config-ssh, this change prevents their use:

❯ go run ./cmd/coder config-ssh yes
accepts 0 arg(s), received 1
Run 'coder config-ssh --help' for usage.
exit status 1

@mafredri mafredri self-assigned this Aug 6, 2022
@mafredri mafredri requested a review from kylecarbs August 6, 2022 09:10
@mafredri mafredri merged commit 1fb274c into main Aug 6, 2022
@mafredri mafredri deleted the mafredri/cli-configssh-no-args branch August 6, 2022 17:56
@OlgaKhmelevskaya
Copy link

Hello @mafredri , could you please add reference to the issue this pull request is related to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @OlgaKhmelevskaya @kylecarbs
0