8000 refactor: Downsize the search bar a bit by BrunoQuaresma · Pull Request #2789 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

refactor: Downsize the search bar a bit #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2022
Merged

refactor: Downsize the search bar a bit #2789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6df21d
refactor: Downsize the search bar a bit
BrunoQuaresma Jul 1, 2022
b0e9e3e
Fix filter height
BrunoQuaresma Jul 1, 2022
c35ab13
Move logic to the search bar
BrunoQuaresma Jul 1, 2022
cb0c99c
Fix component
BrunoQuaresma Jul 1, 2022
File filter

Filter by extension

Filter by extension
10000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move logic to the search bar
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jul 1, 2022
commit c35ab135394f2aadfeaf4286bbd16753b5450dcd
8 changes: 8 additions & 0 deletions site/src/components/SearchBarWithFilter/SearchBarWithFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export const SearchBarWithFilter: React.FC<SearchBarWithFilterProps> = ({
value={form.values.query}
error={!!error}
className={styles.inputStyles}
classNames={{ OutlinedInput: styles.outlinedInput }}
onChange={form.handleChange}
startAdornment={
<InputAdornment position="start" className={styles.searchIcon}>
Expand Down Expand Up @@ -183,6 +184,13 @@ const useStyles = makeStyles<Theme, StyleProps>((theme) => ({
borderColor: (props) => props.error && theme.palette.error.contrastText,
},
},

"& .MuiInputBase-input": {
paddingTop: "inherit",
paddingBottom: "inherit",
// The same as the button
minHeight: 42,
},
},
searchIcon: {
color: theme.palette.text.secondary,
Expand Down
7 changes: 0 additions & 7 deletions site/src/theme/overrides.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,6 @@ export const getOverrides = (palette: PaletteOptions) => {
borderColor: (palette.primary as SimplePaletteColorOptions).light,
},
},

input: {
paddingTop: "inherit",
paddingBottom: "inherit",
// The same as the button
minHeight: 42,
},
},
MuiLink: {
root: {
Expand Down
0