8000 feat: Add filter on Users page by AbhineetJain · Pull Request #2653 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: Add filter on Users page #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2022
Merged

feat: Add filter on Users page #2653

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
acbd54a
Add filter search on Users page
AbhineetJain Jun 24, 2022
be7eaac
Handle filter form errors
AbhineetJain Jun 25, 2022
186425e
Fix stories
AbhineetJain Jun 25, 2022
bfbf729
refactor code
AbhineetJain Jun 28, 2022
3f309aa
refactor UsersTable into separate components
AbhineetJain Jun 28, 2022
a7f7171
pause animation for isLoading story
AbhineetJain Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
pause animation for isLoading story
  • Loading branch information
@AbhineetJain
AbhineetJain committed Jun 28, 2022
commit a7f7171f5446fc2da26fa1cee24ad5d6f8a14df2
3 changes: 3 additions & 0 deletions site/src/components/UsersTable/UsersTable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,6 @@ Loading.args = {
roles: MockSiteRoles,
isLoading: true,
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this story since it tests a particular behavior of the component, but I am not sure if it is a good UI snapshot since the loader is spinning and the snapshot may change across different builds. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thought. I haven't read through this in detail, but could we pause the animation for the loader? Or introduce a slight delay? https://www.chromatic.com/docs/animations

Copy link
Contributor Author
5B1F

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing to this, I used

Loading.parameters = {
  chromatic: { pauseAnimationAtEnd: true },
}

and it seems to be constant for at least 3 builds.

Loading.parameters = {
chromatic: { pauseAnimationAtEnd: true },
}
0