8000 Wrap code text in readme files on template page by AbhineetJain · Pull Request #2562 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

Wrap code text in readme files on template page #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2022
Merged

Wrap code text in readme files on template page #2562

merged 1 commit into from
Jun 22, 2022

Conversation

AbhineetJain
Copy link
Contributor
@AbhineetJain AbhineetJain commented Jun 21, 2022 •
edited
Loading

This PR wraps the code portion in template README files.

Subtasks

  • add relevant CSS
  • add story

Fixes #2298
Fixes #2385

Screenshot

Screen Shot 2022-06-21 at 3 58 12 PM

@AbhineetJain AbhineetJain requested a review from a team as a code owner June 21, 2022 19:58
Kira-Pilot
Kira-Pilot reviewed Jun 22, 2022
View reviewed changes
site/src/pages/TemplatePage/TemplatePageView.stories.tsx
\`\`\`
# This is a really long sentence to test that the code block wraps into a new line properly.
\`\`\``,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the way you tested this with a visual story instead of trying to locate the styles in a unit test.

@AbhineetJain AbhineetJain merged commit bd19fcb into main Jun 22, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/2298-template-overflow-readme branch June 22, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text is not wrapped in Templates->README Text Overflow on Template readme
2 participants
@AbhineetJain @Kira-Pilot
0