8000 Condense footer by ammario · Pull Request #2555 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

Condense footer #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2022
Merged

Condense footer #2555

merged 1 commit into from
Jun 21, 2022

Conversation

ammario
Copy link
Member
@ammario ammario commented Jun 21, 2022

Since the footer is included in every page, we should try extra
hard to use little vertical space.

Also, I add an icon to the version text for balance.

Before:
image

After:
image

@ammario
Condense footer
d03684a 
Since the footer is included in every page, we should try extra
hard to use litt
8000
le vertical space.

Also, I add an icon to the version text for balance.
@ammario ammario requested a review from Kira-Pilot June 21, 2022 16:43
@ammario ammario requested a review from a team as a code owner June 21, 2022 16:43
@ammario ammario enabled auto-merge (squash) June 21, 2022 16:43
kylecarbs
kylecarbs reviewed Jun 21, 2022
View reviewed changes
Copy link
Member
@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make the copyright smaller than these other links. It's not very important, but the other two are!

@ammario ammario disabled auto-merge June 21, 2022 16:46
@ammario ammario enabled auto-merge (squash) June 21, 2022 16:48
@Kira-Pilot
Copy link
Member

ah, this is much better! I agree with Kyle's remark about the font size.

Kira-Pilot
Kira-Pilot reviewed Jun 21, 2022
View reviewed changes
site/src/components/Footer/Footer.tsx
<div className={styles.copyRight}>{Language.copyrightText}</div>
{buildInfo && (
<div className={styles.buildInfo}>
<Link className={styles.link} variant="caption" target="_blank" href={buildInfo.external_url}>
{Language.buildInfoText(buildInfo)}
<AccountTreeIcon className={styles.icon} /> {Language.buildInfoText(buildInfo)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ammario ammario merged commit 9d02a37 into main Jun 21, 2022
@ammario ammario deleted the feedback-widget branch June 21, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs left review comments

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammario @Kira-Pilot @kylecarbs
0