8000 feat: add feedback link to footer by Kira-Pilot · Pull Request #2447 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add feedback link to footer #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 17, 2022
Merged

feat: add feedback link to footer #2447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7a322f4
add ability to activate users
Kira-Pilot Jun 14, 2022
88643c6
added test
Kira-Pilot Jun 15, 2022
26ace52
Merge remote-tracking branch 'origin/main' into ability-to-activate/k…
Kira-Pilot Jun 15, 2022
9a232a8
PR feedback
Kira-Pilot Jun 15, 2022
c778ea0
guarding against null validation_contains field
Kira-Pilot Jun 15, 2022
b2e9596
Merge remote-tracking branch 'origin/main' into add-schema-null-guard…
Kira-Pilot Jun 15, 2022
f8dcb1b
fixing type for ParameterSchema
Kira-Pilot Jun 15, 2022
3e0735e
added report link to footer
Kira-Pilot Jun 16, 2022
05ebd57
Merge remote-tracking branch 'origin/main' into add-bug-report-link/k…
Kira-Pilot Jun 16, 2022
42f0533
added test
Kira-Pilot Jun 16, 2022
a2ae1cf
Merge remote-tracking branch 'origin/main' into add-bug-report-link/k…
Kira-Pilot Jun 16, 2022
7143343
Merge remote-tracking branch 'origin/main' into add-bug-report-link/k…
Kira-Pilot Jun 17, 2022
a181dd5
Footer story
8000 Kira-Pilot Jun 17, 2022
3df0b84
fix broken test
Kira-Pilot Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added test
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed Jun 16, 2022
commit 42f05335aaddd8a8e08a7bf42e84ba0d8afc23e0
12 changes: 0 additions & 12 deletions site/src/components/Footer/Footer.stories.tsx
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions site/src/components/Footer/Footer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,13 @@ describe("Footer", () => {
// Then
await screen.findByText("Copyright", { exact: false })
await screen.findByText(Language.buildInfoText(MockBuildInfo))
const reportBugLink = screen.getByText(Language.reportBugLink, { exact: false }).closest("a")
if (!reportBugLink) {
throw new Error("Bug report link not found in footer")
}

expect(reportBugLink.getAttribute("href")).toBe(
`https://github.com/coder/coder/issues/new?labels=bug,needs+grooming&title=Bug+in+${MockBuildInfo.version}:&template=external_bug_report.md`,
)
})
})
2 changes: 1 addition & 1 deletion site/src/components/Footer/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const Language = {
return `Coder ${buildInfo.version}`
},
copyrightText: `Copyright \u00a9 ${new Date().getFullYear()} Coder Technologies, Inc. All rights reserved.`,
reportBugLink: "Report an issue ->",
reportBugLink: "Report an issue",
}

export const Footer: React.FC = ({ children }) => {
Expand Down
0