10000 feat: update workspace deadline when workspace ttl updated by johnstcn · Pull Request #2165 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat: update workspace deadline when workspace ttl updated #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 9, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address PR comments
  • Loading branch information
johnstcn committed Jun 9, 2022
commit a4c07df7b76c996a4164c15b997ffcba10bb70b2
2 changes: 1 addition & 1 deletion cli/ttl.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func ttlset() *cobra.Command {
Default: "yes",
IsConfirm: true,
})
if errors.Is(err, cliui.Canceled) {
if errors.Is(err, cliui.Canceled) || err != nil {
return nil
}
}
Expand Down
1 change: 0 additions & 1 deletion coderd/workspaces.go
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,6 @@ func (api *API) putWorkspaceTTL(rw http.ResponseWriter, r *http.Request) {
); err != nil {
return xerrors.Errorf("update workspace deadline: %w", err)
}

return nil
})

Expand Down
0