8000 fix: bug where all workspaces filter defaulted to 'me' by f0ssel · Pull Request #2145 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

fix: bug where all workspaces filter defaulted to 'me' #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files. Retry
Loading
Diff view
Diff view
Next Next commit
fix: bug where all workspaces filter defaulted to 'me'
  • Loading branch information
f0ssel committed Jun 7, 2022
commit b84874f3109049ec33dc32b497fc43920744550d
2 changes: 1 addition & 1 deletion site/src/pages/WorkspacesPage/WorkspacesPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const WorkspacesPage: FC = () => {

useEffect(() => {
const filter = searchParams.get("filter")
const query = filter ? filter : workspaceFilterQuery.me
const query = filter !== null ? filter : workspaceFilterQuery.me

send({
type: "SET_FILTER",
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/WorkspacesPage/WorkspacesPageView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import { Margins } from "../../components/Margins/Margins"
import { PageHeader, PageHeaderTitle } from "../../components/PageHeader/PageHeader"
import { Stack } from "../../components/Stack/Stack"
import { TableLoader } from "../../components/TableLoader/TableLoader"
import { getFormHelpers, onChangeTrimmed } from "../../util/formUtils"
import { getFormHelpers } from "../../util/formUtils"
import { getDisplayStatus, workspaceFilterQuery } from "../../util/workspace"

dayjs.extend(relativeTime)
Expand Down Expand Up @@ -156,7 +156,7 @@ export const WorkspacesPageView: FC<WorkspacesPageViewProps> = ({ loading, works
<TextField
{...getFieldHelpers("query")}
className={styles.textFieldRoot}
onChange={onChangeTrimmed(form)}
onChange={form.handleChange}
fullWidth
variant="outlined"
InputProps={{
Expand Down
0