8000 fix: add workspace option 'deleted' to options type by f0ssel · Pull Request #2095 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: add workspace option 'deleted' to options type #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2022
Merged

fix: add workspace option 'deleted' to options type #2095

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cde62a
fix: add workspace option 'deleted' to options type
f0ssel Jun 6, 2022
3de6806
dead code
f0ssel Jun 6, 2022
f19c0ed
fix go test
f0ssel Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000
Diff view
Diff view
Prev Previous commit
fix go test
  • Loading branch information
@f0ssel
f0ssel committed Jun 6, 2022
commit f19c0edfefc85c6b17ecded8c5128b9686692b6f
5 changes: 2 additions & 3 deletions coderd/workspaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,9 @@ func TestWorkspace(t *testing.T) {
workspace := coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID)
coderdtest.AwaitWorkspaceBuildJob(t, client, workspace.LatestBuild.ID)

// Getting with deleted=true should fail.
// Getting with deleted=true should still work.
_, err := client.DeletedWorkspace(context.Background(), workspace.ID)
require.Error(t, err)
require.ErrorContains(t, err, "400") // bad request
require.NoError(t, err)

// Delete the workspace
build, err := client.CreateWorkspaceBuild(context.Background(), workspace.ID, codersdk.CreateWorkspaceBuildRequest{
Expand Down
0