8000 chore: More UI friendly errors by Emyrk · Pull Request #1994 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

chore: More UI friendly errors #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 3, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove empty switch case
  • Loading branch information
Emyrk committed Jun 3, 2022
commit deb5cf1ad6e8763817b873788f33922be73674d4
6 changes: 0 additions & 6 deletions coderd/parameters.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,12 +226,6 @@ func (api *API) parameterRBACResource(rw http.ResponseWriter, r *http.Request, s
// can add user scoped params.
resource = rbac.ResourceUserData.WithID(user.ID.String()).WithOwner(user.ID.String())
}
case database.ParameterScopeImportJob:
// This scope does not make sense from this api.
// ImportJob params are created with the job, and the job id cannot
// be predicted.
// Just fallthrough to the unsupported error
fallthrough
default:
err = xerrors.Errorf("Parameter scope %q unsupported", scope)
}
Expand Down
0