8000 feat: one-line install script by bpmct · Pull Request #1924 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: one-line install script #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 1, 2022
Merged

feat: one-line install script #1924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
006a805
feat: one-line install script
bpmct May 31, 2022
2724aef
remove homebrew support
bpmct May 31, 2022
f7a5ee8
remove arch linux
bpmct May 31, 2022
c3505ed
use proper filename for packages
bpmct May 31, 2022
5d23600
fix variable format
bpmct May 31, 2022
936c466
fix systemd instructions
bpmct May 31, 2022
086e30e
fixes to standalone script
bpmct May 31, 2022
3a65b94
fix missing var bugs
bpmct May 31, 2022
26ab867
fix standalone install
bpmct May 31, 2022
3568085
fix for MacOS
bpmct May 31, 2022
a022e3b
format
bpmct May 31, 2022
038dc8c
fix armv7 assets and zips
bpmct May 31, 2022
fa59da0
remove windows
bpmct May 31, 2022
bec5584
update install docs
bpmct Jun 1, 2022
c308d60
support external sources with shellcheck
bpmct Jun 1, 2022
8989211
shfmt
bpmct Jun 1, 2022
cf1912a
add external sources to GitHub action & unfold
bpmct Jun 1, 2022
a611c7b
change wording
bpmct Jun 1, 2022
a16a04a
first template docs
bpmct Jun 1, 2022
6879752
default to /usr/local instead
bpmct Jun 1, 2022
8cba04c
add option for binary name
bpmct Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add external sources to GitHub action & unfold
  • Loading branch information
@bpmct
bpmct committed Jun 1, 2022
commit cf1912a6c1159170904b653fa6e6be0afccf9c16
2 changes: 2 additions & 0 deletions .github/workflows/coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ jobs:
- uses: actions/checkout@v3
- name: Run ShellCheck
uses: ludeeus/action-shellcheck@1.1.0
env:
SHELLCHECK_OPTS: --external-sources
Comment on lines +55 to +56
Copy link
Member Author
@bpmct bpmct Jun 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolved some warnings around unspecified inputs. See https://www.mankier.com/1/shellcheck#-x and koalaman/shellcheck#902

The error was only for `/etc/os-release` in the script 
$ make lint/shellcheck
In install.sh line 424:
                        . /etc/os-release
                          ^-------------^ SC1091: Not following: /etc/os-release was not specified as input (see shellcheck -x).


In install.sh line 450:
                        . /etc/os-release
                          ^-------------^ SC1091: Not following: /etc/os-release was not specified as input (see shellcheck -x).

with:
ignore: node_modules

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ lint/go:
# Use shfmt to determine the shell files, takes editorconfig into consideration.
lint/shellcheck: $(shell shfmt -f .)
@echo "--- shellcheck"
shellcheck -x $(shell shfmt -f .)
shellcheck --external-sources $(shell shfmt -f .)

peerbroker/proto/peerbroker.pb.go: peerbroker/proto/peerbroker.proto
protoc \
Expand Down
0