8000 feat(examples/templates): add `docker-devcontainer` template and rename envbuilder template by mafredri · Pull Request #18741 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat(examples/templates): add docker-devcontainer template and rename envbuilder template #18741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 3, 2025
Prev Previous commit
Next Next commit
discourage rather than mention possibility
  • Loading branch information
mafredri committed Jul 3, 2025
commit 68a298f78e4dd06af49f111be46146083b1d35fa
7 changes: 3 additions & 4 deletions examples/templates/docker-devcontainer/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -315,12 +315,11 @@ resource "docker_container" "workspace" {
image = local.workspace_image

# NOTE: The `privileged` mode is one way to run Docker-in-Docker,
# which is required for the devcontainer to work. IF this is not
# which is required for the devcontainer to work. If this is not
# desired, you can remove this line. However, you will need to ensure
# that the devcontainer can run Docker commands in some other way.
# Mounting the host Docker socket is one way to do this, but it is
# strongly discouraged because workspaces will then compete for
# control of the devcontainers.
# Mounting the host Docker socket is strongly discouraged because
# workspaces will then compete for control of the devcontainers.
privileged = true

# Uses lower() to avoid Docker restriction on container names.
Expand Down
Loading
0