10000 fix(agent/agentcontainers): split Init into Init and Start for early API responses by mafredri · Pull Request #18640 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix(agent/agentcontainers): split Init into Init and Start for early API responses #18640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

fix(agent/agentcontainers): split Init into Init and Start for early API responses #18640

merged 2 commits into from
Jun 27, 2025

Conversation

mafredri
Copy link
Member
@mafredri mafredri commented Jun 27, 2025 •
edited
Loading

Previously in #18635 we delayed the containers API Init to avoid producing errors due to Docker and @devcontainers/cli not yet being installed by startup scripts. This had an adverse effect on the UX via UI responsiveness as the detection of devcontainers was greatly delayed.

This change splits Init into Init and Start so that we can immediately after Init start serving known devcontainers (defined in Terraform), improving the UX.

Related #18635
Related #18640

8000
DanielleMaywood
DanielleMaywood approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor
@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this one does it 😄

@mafredri mafredri marked this pull request as ready for review June 27, 2025 15:52
@mafredri mafredri merged commit 0f3a1e9 into main Jun 27, 2025
38 checks passed
@mafredri mafredri deleted the mafredri/fix-agent-agentcontainers-init-start branch June 27, 2025 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @DanielleMaywood
0