8000 feat(site): display devcontainer start error by DanielleMaywood · Pull Request #18637 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat(site): display devcontainer start error #18637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 30, 2025
Merged

feat(site): display devcontainer start error #18637

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e094e22
feat(site): surface devcontainer start error
DanielleMaywood Jun 27, 2025
8989dbb
Merge branch 'main' into danielle/surface-devcontainer-errors
DanielleMaywood Jun 30, 2025
220f25f
test: add specific test (and fix bug)
DanielleMaywood Jun 30, 2025
a3cc8e7
chore: appease formatter and linter
DanielleMaywood Jun 30, 2025
e147688
test: skip on windows
DanielleMaywood Jun 30, 2025
59bdade
chore: add error story
DanielleMaywood Jun 30, 2025
ece1fc0
chore: a devcontainer with an error will not have an agent
DanielleMaywood Jun 30, 2025
525337f
chore: feedback
DanielleMaywood Jun 30, 2025
08576b1
chore: also surface errors on 'devcontainer up'
DanielleMaywood Jun 30, 2025
9412417
chore: comment
DanielleMaywood Jun 30, 2025
c0b9d12
chore: appease linter
DanielleMaywood Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: appease formatter and linter
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Jun 30, 2025
commit a3cc8e7a05c9e6e7f5df690baec30cdb22494255
3 changes: 1 addition & 2 deletions agent/agentcontainers/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package agentcontainers_test
import (
"context"
"encoding/json"
"errors"
"fmt"
"math/rand"
"net/http"
Expand Down Expand Up @@ -1687,7 +1686,7 @@ func TestAPI(t *testing.T) {

// We're going to force the container CLI to fail, which will allow us to test the
// error handling.
var simulatedError = errors.New("simulated error")
simulatedError := xerrors.New("simulated error")
mCCLI.EXPECT().DetectArchitecture(gomock.Any(), testContainer.ID).Return("", simulatedError).Times(1)

mClock.Set(time.Now()).MustWait(ctx)
Expand Down
2 changes: 1 addition & 1 deletion site/src/modules/resources/AgentDevcontainerCard.tsx
View file
Open in desktop
F8C5
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { AppStatuses } from "pages/WorkspacePage/AppStatuses";
import type { FC } from "react";
import { useEffect } from "react";
import { useMutation, useQueryClient } from "react-query";
import { cn } from "utils/cn";
import { portForwardURL } from "utils/portForward";
import { AgentApps, organizeAgentApps } from "./AgentApps/AgentApps";
import { AgentButton } from "./AgentButton";
Expand All @@ -34,7 +35,6 @@ import { AgentSSHButton } from "./SSHButton/SSHButton";
import { SubAgentOutdatedTooltip } from "./SubAgentOutdatedTooltip";
import { TerminalLink } from "./TerminalLink/TerminalLink";
import { VSCodeDevContainerButton } from "./VSCodeDevContainerButton/VSCodeDevContainerButton";
import { cn } from "utils/cn";

type AgentDevcontainerCardProps = {
parentAgent: WorkspaceAgent;
Expand Down
4 changes: 2 additions & 2 deletions site/src/modules/resources/AgentStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ export const AgentStatus: FC<AgentStatusProps> = ({ agent }) => {
);
};

export const SubAgentStatus: FC<SubAgentStatusProps> = ({ agent }) => {
const SubAgentStatus: FC<SubAgentStatusProps> = ({ agent }) => {
if (!agent) {
return <DisconnectedStatus />;
}
Expand All @@ -305,7 +305,7 @@ export const SubAgentStatus: FC<SubAgentStatusProps> = ({ agent }) => {
);
};

export const DevcontainerStartError: FC<AgentStatusProps> = ({ agent }) => {
const DevcontainerStartError: FC<AgentStatusProps> = ({ agent }) => {
return (
<HelpTooltip>
<PopoverTrigger role="status" aria-label="Start error">
Expand Down
Loading
0