8000 fix: use default preset when creating a workspace for task by BrunoQuaresma · Pull Request #18623 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: use default preset when creating a workspace for task #18623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

fix: use default preset when creating a workspace for task #18623

merged 2 commits into from
Jun 27, 2025
+9 −4

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Jun 26, 2025
@BrunoQuaresma BrunoQuaresma mentioned this pull request Jun 26, 2025
Open
@dannykopping dannykopping force-pushed the bq/fix-prebuild-for-tasks branch from c943a05 to 2ab771c Compare June 27, 2025 09:06
dannykopping
dannykopping reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor
@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but don't we need a test?

@BrunoQuaresma
Copy link
Collaborator Author
BrunoQuaresma commented Jun 27, 2025 •
edited
Loading

Looks good but don't we need a test?

It would be great, but in the way we 8000 have the fetch calls structured/abstracted right now, it makes testing this quite painful. Since this is going to be a BE endpoint any time soon, I would not invest time on refactoring to make it more testable.

Wdyt @code-asher ?

@BrunoQuaresma BrunoQuaresma merged commit 6d305df into main Jun 27, 2025
53 of 54 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-prebuild-for-tasks branch June 27, 2025 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
@BrunoQuaresma
Copy link
Collaborator Author

It is merged, but I'm open to add tests in case we find out a good solution for it.

@dannykopping
Copy link
Contributor

Not even a storybook?

@BrunoQuaresma
Copy link
Collaborator Author

Not even a storybook?

It already has a storybook 🤔

@dannykopping
Copy link
Contributor

For tasks?

@BrunoQuaresma
Copy link
Collaborator Author

@dannykopping yeap. https://624de63c6aacee003aa84340-vugffdpsdx.chromatic.com/?path=/story/pages-taskspage--loading-ai-templates

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping left review comments

@code-asher code-asher 539E code-asher approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @dannykopping @code-asher
0