8000 feat: allow masking workspace parameter inputs by aslilac · Pull Request #18595 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: allow masking workspace parameter inputs #18595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: allow masking workspace parameter inputs #18595

wants to merge 15 commits into from

Conversation

aslilac
Copy link
Member
@aslilac aslilac commented Jun 25, 2025 •
edited
Loading

Closes coder/preview#140

Screenshot 2025-06-27 at 2 32 12 PM Screenshot 2025-06-27 at 2 32 33 PM

Allows you to set mask_input on a coder_parameter to turn it into a "secret" input. Works for form_types of "textarea" and "input".

data "coder_parameter" "a" {
  // ...
  styling = {
    mask_input = true
  }
}

@aslilac aslilac requested a review from jaaydenh June 26, 2025 23:58
@aslilac aslilac marked this pull request as ready for review June 26, 2025 23:58
@jaaydenh
Copy link
Contributor

Im seeing a misalignment of the Eye button for the Input
Screenshot 2025-06-27 at 16 29 08

@jaaydenh
Copy link
Contributor

For the textarea the eye icon is tricky to place because of the placeholder and when resizing the textarea the eye icon doesn't move with the textarea because its absolute positioning. It may be easier to place the eye icon outside to the right of the textarea/input.

Screenshot 2025-06-27 at 16 33 17 Screenshot 2025-06-27 at 16 33 40

@aslilac
Copy link
Member Author
aslilac commented Jun 27, 2025

@jaaydenh thanks for checking the styles. I think the autofill widget that 1password inserts must've been messing with me. putting the toggle on the outside is a lot more consistent (and doesn't risk covering text content)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaaydenh jaaydenh Awaiting requested review from jaaydenh

At least 1 approving review is required to merge this pull request.

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic Paramters: Add maskInput styling option for input and textarea form types
2 participants
@aslilac @jaaydenh
0