chore: fix idle state icon when disabled #18554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the workspace is off, we set a disabled color, but for the idle icon that also needs a fill, this only changed the border making it look weird. Instead, move the disabled logic into the component so we can apply a matching fill when necessary.
ed86e1f to
27f64de
Compare
hugodutka
approved these changes
Jun 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the workspace is off, we set a disabled text/stroke color, but for the idle icon that also needs a fill, this only changed the outline making it look weird. Instead, move the disabled logic into the component so we can apply a matching fill.
I felt it looked too thick with both the outline and fill, so I also removed the outline.
Really I think maybe the workspace status should be a separate column rather than disabling these icons, but this maintains the status quo.
Before with mismatching stroke and fill color:
After with disabled fill and stroke removal:
Enabled fill and stroke removal: