8000 fix(agent): start devcontainers through agentcontainers package by DanielleMaywood · Pull Request #18471 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

fix(agent): start devcontainers through agentcontainers package #18471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 25, 2025
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
978c871
fix(agent): start devcontainers through agentcontainers package
DanielleMaywood Jun 20, 2025
fe99bd6
chore: appease formatter
DanielleMaywood Jun 20, 2025
aeae6e2
chore: fix test, appease linter
DanielleMaywood Jun 20, 2025
916f7e8
chore: feedback
DanielleMaywood Jun 24, 2025
53e256b
Merge branch 'main' into dm-devcontainer-log-spam
DanielleMaywood Jun 24, 2025
91bb43a
chore: re-add script timings
DanielleMaywood Jun 24, 2025
81fe11d
fix: change how containerAPI is stored
DanielleMaywood Jun 24, 2025
5c70a8c
Merge branch 'main' into dm-devcontainer-log-spam
DanielleMaywood Jun 24, 2025
8437ca4
chore: appease linter
DanielleMaywood Jun 24, 2025
2c6a2b1
chore: ensure the last log line is printed
DanielleMaywood Jun 24, 2025
a512ad4
chore: fix typo
DanielleMaywood Jun 24, 2025
c50dc6e
chore: OOPS
DanielleMaywood Jun 24, 2025
4d40ef2
chore: 1 -> 2
DanielleMaywood Jun 24, 2025
ce32e2e
chore: add a status to the timings
DanielleMaywood Jun 24, 2025
32ac48a
chore: initialize containerapi even earlier
DanielleMaywood Jun 24, 2025
738b755
chore: only enable when devcontainers are enabled
DanielleMaywood Jun 24, 2025
3714fec
chore: simplify things a little
DanielleMaywood Jun 24, 2025
996d440
chore: recreate -> create with argument
DanielleMaywood Jun 24, 2025
ae5dd1e
chore: ensure we close and init
DanielleMaywood Jun 24, 2025
9d76cf6
chore: appease linter
DanielleMaywood Jun 24, 2025
7285c39
chore: mock ReadConfig any time
DanielleMaywood Jun 24, 2025
3fce51c
chore: feedback
DanielleMaywood Jun 25, 2025
54aa84a
chore: feedback
DanielleMaywood Jun 25, 2025
3d08d0e
chore: only set status if not set, and run create in test
DanielleMaywood Jun 25, 2025
fa479fc
chore: feedback on poor error message
DanielleMaywood Jun 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add a status to the timings
  • Loading branch information
DanielleMaywood committed Jun 24, 2025
commit ce32e2e2d9c06651936311359916cc7623b9c656
3 changes: 3 additions & 0 deletions agent/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -1238,9 +1238,11 @@ func (a *agent) createDevcontainer(
var (
exitCode = int32(0)
startTime = a.clock.Now()
status = proto.Timing_OK
)
if err = cAPI.CreateDevcontainer(dc); err != nil {
exitCode = 1
status = proto.Timing_EXIT_FAILURE
}
endTime := a.clock.Now()

Expand All @@ -1251,6 +1253,7 @@ func (a *agent) createDevcontainer(
End: timestamppb.New(endTime),
ExitCode: exitCode,
Stage: proto.Timing_START,
Status: status,
},
}); scriptErr != nil {
a.logger.Warn(ctx, "reporting script completed failed", slog.Error(scriptErr))
Expand Down
0