-
Notifications
You must be signed in to change notification settings - Fork 944
chore: refactor dynamic parameters into dedicated package #18420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1ca9483
wip
Emyrk d4dab77
refactor and move dynamic param rendering
Emyrk c50ee08
fixup FileError test
Emyrk 8152bb7
more wip
Emyrk 247470e
chore: add dynamic parameter unit test
Emyrk 6799896
add another dynamic param
Emyrk 08bffe2
add some comments
Emyrk f651edc
fmt
Emyrk 67644cc
remove need to constantly send owner id
Emyrk ea4aa7d
linting
Emyrk 758cd26
refactor loader
Emyrk e8f1d2d
comments
Emyrk 23840d9
linting
Emyrk 6328899
add idea
Emyrk cd46813
merge in main
Emyrk 21b24d2
spelling
Emyrk 7a1622d
add comment, remove unused field
Emyrk db612b3
chore: reprot json error as param diagnostic
Emyrk 000f722
minor fixes
Emyrk 7b80138
only use 1 function, not a 2 step
Emyrk c1902a7
Revert "only use 1 function, not a 2 step"
Emyrk d2634e2
only use 1 function, not a 2 step
Emyrk 21ce54b
refactor TemplateVersionParameter to be a converter func
Emyrk ae82770
Merge branch 'main' into stevenmasley/dynamic_param_pkg
Emyrk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fmt
- Loading branch information
commit f651edc773663a37aa0e1ddab2970e4d0df0ee5b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.