8000 fix: use tailscale that avoids small MTU paths by spikecurtis · Pull Request #18323 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: use tailscale that avoids small MTU paths #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

fix: use tailscale that avoids small MTU paths #18323

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e3de68
fix: use tailscale that avoids small MTU paths
spikecurtis Jun 11, 2025
830d299
fewer lies
spikecurtis Jun 11, 2025
3d1ea85
make router ::1 address
spikecurtis Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make router ::1 address
  • Loading branch information
@spikecurtis
spikecurtis committed Jun 11, 2025
commit 3d1ea85804f5b2969132f45d5dcdf21d48fa9927
34 changes: 17 additions & 17 deletions tailnet/test/integration/network.go
View file
Open in desktop
5D59
Original file line number Diff line number Diff line change
Expand Up @@ -409,17 +409,17 @@ type fakeTriangleNetwork struct {
// . ┌──────────────┐
// . │ │
// . │ Server ├─────────────────────────────────────┐
// . │ │fdac:38fa:ffff:3::1 │
// . └──────────────┘ │ fdac:38fa:ffff:3::2
// . │ │fdac:38fa:ffff:3::2 │
// . └──────────────┘ │ fdac:38fa:ffff:3::1
// . ┌──────────────┐ ┌─────┴───────┐
// . │ │ fdac:38fa:ffff:1::2│ │
// . │ │ fdac:38fa:ffff:1::1│ │
// . │ Client 1 ├───────────────────────────────┤ Router │
// . │ │fdac:38fa:ffff:1::1 │ │
// . │ │fdac:38fa:ffff:1::2 │ │
// . └──────────────┘ └─────┬───────┘
// . ┌──────────────┐ │ fdac:38fa:ffff:2::2
// . ┌──────────────┐ │ fdac:38fa:ffff:2::1
// . │ │ │
// . │ Client 2 ├─────────────────────────────────────┘
// . │ │fdac:38fa:ffff:2::1
// . │ │fdac:38fa:ffff:2::2
// . └──────────────┘
// The veth link between Client 1 and the router has a configurable MTU via Client1MTU.
func (n TriangleNetwork) SetupNetworking(t *testing.T, l slog.Logger) TestNetworking {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really a triangle anymore unfortunately, more of a pitchfork 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untitled.jpg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should redo the diagram to be triforce 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure unicode has the correct (60°) diagonals

Expand Down Expand Up @@ -488,18 +488,18 @@ func (n TriangleNetwork) SetupNetworking(t *testing.T, l slog.Logger) TestNetwor
require.NoErrorf(t, err, "set veth %q to client2 NetNS", network.Client2VethPair.Inner)

// Set IP addresses according to the diagram:
err = setInterfaceIP6(network.ServerNetNS, network.ServerVethPair.Outer, ula+"3::1")
err = setInterfaceIP6(network.ServerNetNS, network.ServerVethPair.Outer, ula+"3::2")
require.NoErrorf(t, err, "set IP on server interface")
err = setInterfaceIP6(network.Client1NetNS, network.Client1VethPair.Outer, ula+"1::1")
err = setInterfaceIP6(network.Client1NetNS, network.Client1VethPair.Outer, ula+"1::2")
require.NoErrorf(t, err, "set IP on client1 interface")
err = setInterfaceIP6(network.Client2NetNS, network.Client2VethPair.Outer, ula+"2::1")
err = setInterfaceIP6(network.Client2NetNS, network.Client2VethPair.Outer, ula+"2::2")
require.NoErrorf(t, err, "set IP on client2 interface")

err = setInterfaceIP6(network.RouterNetNS, network.ServerVethPair.Inner, ula+"3::2")
err = setInterfaceIP6(network.RouterNetNS, network.ServerVethPair.Inner, ula+"3::1")
require.NoErrorf(t, err, "set IP on router-server interface")
err = setInterfaceIP6(network.RouterNetNS, network.Client1VethPair.Inner, ula+"1::2")
err = setInterfaceIP6(network.RouterNetNS, network.Client1VethPair.Inner, ula+"1::1")
require.NoErrorf(t, err, "set IP on router-client1 interface")
err = setInterfaceIP6(network.RouterNetNS, network.Client2VethPair.Inner, ula+"2::2")
err = setInterfaceIP6(network.RouterNetNS, network.Client2VethPair.Inner, ula+"2::1")
require.NoErrorf(t, err, "set IP on router-client2 interface")

// Bring up all interfaces
Expand All @@ -508,9 +508,9 @@ func (n TriangleNetwork) SetupNetworking(t *testing.T, l slog.Logger) TestNetwor
ifaceName string
defaultRoute string
}{
{network.ServerNetNS, network.ServerVethPair.Outer, ula + "3::2"},
{network.Client1NetNS, network.Client1VethPair.Outer, ula + "1::2"},
{network.Client2NetNS, network.Client2VethPair.Outer, ula + "2::2"},
{network.ServerNetNS, network.ServerVethPair.Outer, ula + "3::1"},
{network.Client1NetNS, network.Client1VethPair.Outer, ula + "1::1"},
{network.Client2NetNS, network.Client2VethPair.Outer, ula + "2::1"},
{network.RouterNetNS, network.ServerVethPair.Inner, ""},
{network.RouterNetNS, network.Client1VethPair.Inner, ""},
{network.RouterNetNS, network.Client2VethPair.Inner, ""},
Expand All @@ -536,11 +536,11 @@ func (n TriangleNetwork) SetupNetworking(t *testing.T, l slog.Logger) TestNetwor
},
Client1: TestNetworkingClient{
Process: TestNetworkingProcess{NetNS: network.Client1NetNS},
ServerAccessURL: "http://[" + ula + "3::1]:8080",
ServerAccessURL: "http://[" + ula + "3::2]:8080",
},
Client2: TestNetworkingClient{
Process: TestNetworkingProcess{NetNS: network.Client2NetNS},
ServerAccessURL: "http://[" + ula + "3::1]:8080",
ServerAccessURL: "http://[" + ula + "3::2]:8080",
},
}
}
Expand Down
Loading
0