8000 feat: port forwarding dropdown by code-asher · Pull Request #1824 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat: port forwarding dropdown #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add utility for extracting error message
  • Loading branch information
code-asher committed May 27, 2022
commit c2a185150b2a02af07b89afef423f68d6c2718cb
20 changes: 20 additions & 0 deletions site/src/util/error.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { errorString, Language } from "./error"

describe("error", () => {
describe("errorStr", () => {
it("returns message if error", () => {
expect(errorString(new Error("foobar"))).toBe("foobar")
})
it("returns message if string", () => {
expect(errorString("bazzle")).toBe("bazzle")
})
it("returns message if undefined or empty", () => {
expect(errorString(undefined)).toBe(Language.noError)
expect(errorString("")).toBe(Language.noError)
})
it("returns message if anything else", () => {
expect(errorString({ qux: "fred" })).toBe(Language.unexpectedError)
expect(errorString({ qux: 1 })).toBe(Language.unexpectedError)
})
})
})
20 changes: 20 additions & 0 deletions site/src/util/error.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
export const Language = {
unexpectedError: "Unexpected error: see console for details",
noError: "No error provided",
}

/**
* Best effort to get a string from what could be an error or anything else.
*/
export const errorString = (error: Error | unknown): string | undefined => {
if (error instanceof Error) {
return error.message
} else if (typeof error === "string") {
return error || Language.noError
} else if (typeof error !== "undefined") {
console.warn(error)
return Language.unexpectedError
} else {
return Language.noError
}
}
0