fix: add validation error for duplicate slug names

coder · DanielleMaywood · Jun 5, 2025 · May 30, 2025 · May 30, 2025 · May 30, 2025
commit 5250e1ca7650232b4e656712dc1bb1a3c3d8d090
diff --git a/coderd/agentapi/subagent.go b/coderd/agentapi/subagent.go
@@ -80,6 +80,7 @@ func (a *SubAgentAPI) CreateSubAgent(ctx context.Context, req *agentproto.Create
 		return nil, xerrors.Errorf("insert sub agent: %w", err)
 	}
 
+	appSlugs := make(map[string]struct{})
 	for i, app := range req.Apps {
 		slug := app.Slug
 		if slug == "" {
@@ -94,7 +95,13 @@ func (a *SubAgentAPI) CreateSubAgent(ctx context.Context, req *agentproto.Create
 				Detail: fmt.Sprintf("app slug %q does not match regex %q", slug, provisioner.AppSlugRegex),
 			}
 		}
-
+		if _, exists := appSlugs[slug]; exists {
+			return nil, codersdk.ValidationError{
+				Field:  fmt.Sprintf("apps[%d].slug", i),
+				Detail: fmt.Sprintf("app slug %q is already in use", slug),
+			}
+		}
+		appSlugs[slug] = struct{}{}
 		health := database.WorkspaceAppHealthDisabled
 		if app.Healthcheck == nil {
 			app.Healthcheck = &agentproto.CreateSubAgentRequest_App_Healthcheck{}

diff --git a/coderd/agentapi/subagent_test.go b/coderd/agentapi/subagent_test.go
@@ -471,6 +471,48 @@ func TestSubAgentAPI(t *testing.T) {
 					},
 
ADF7
				},
 			},
+			{
+				name: "DuplicateAppSlugs",
+				apps: []*proto.CreateSubAgentRequest_App{
+					{
+						Slug:        "duplicate-app",
+						DisplayName: ptr.Ref("First App"),
+					},
+					{
+						Slug:        "duplicate-app",
+						DisplayName: ptr.Ref("Second App"),
+					},
+				},
+				expectedError: &codersdk.ValidationError{
+					Field:  "apps[1].slug",
+					Detail: "app slug \"duplicate-app\" is already in use",
+				},
+			},
+			{
+				name: "MultipleDuplicateAppSlugs",
+				apps: []*proto.CreateSubAgentRequest_App{
+					{
+						Slug:        "valid-app",
+						DisplayName: ptr.Ref("Valid App"),
+					},
+					{
+						Slug:        "duplicate-app",
+						DisplayName: ptr.Ref("First Duplicate"),
+					},
+					{
+						Slug:        "duplicate-app",
+						DisplayName: ptr.Ref("Second Duplicate"),
+					},
+					{
+						Slug:        "duplicate-app",
+						DisplayName: ptr.Ref("Third Duplicate"),
+					},
+				},
+				expectedError: &codersdk.ValidationError{
+					Field:  "apps[2].slug",
+					Detail: "app slug \"duplicate-app\" is already in use",
+				},
+			},
 		}
 
 		for _, tt := range tests {