coder · BrunoQuaresma · May 29, 2025 · May 26, 2025 · May 28, 2025 · May 28, 2025
diff --git a/site/src/api/queries/deployment.ts b/site/src/api/queries/deployment.ts
@@ -1,4 +1,5 @@
 import { API } from "api/api";
+import { disabledRefetchOptions } from "./util";
 
 export const deploymentConfigQueryKey = ["deployment", "config"];
 
@@ -26,6 +27,7 @@ export const deploymentStats = () => {
 
 export const deploymentSSHConfig = () => {
 	return {
+		...disabledRefetchOptions,
 		queryKey: ["deployment", "sshConfig"],
 		queryFn: API.getDeploymentSSHConfig,
 	};

diff --git a/site/src/modules/resources/AgentMetadata.tsx b/site/src/modules/resources/AgentMetadata.tsx
@@ -42,24 +42,24 @@ export const AgentMetadataView: FC<AgentMetadataViewProps> = ({ metadata }) => {
 
 interface AgentMetadataProps {
 	agent: WorkspaceAgent;
-	storybookMetadata?: WorkspaceAgentMetadata[];
+	initialMetadata?: WorkspaceAgentMetadata[];
 }
 
 const maxSocketErrorRetryCount = 3;
 
 export const AgentMetadata: FC<AgentMetadataProps> = ({
 	agent,
-	storybookMetadata,
+	initialMetadata,
 }) => {
-	const [activeMetadata, setActiveMetadata] = useState(storybookMetadata);
+	const [activeMetadata, setActiveMetadata] = useState(initialMetadata);
 	useEffect(() => {
 		// This is an unfortunate pitfall with this component's testing setup,
-		// but even though we use the value of storybookMetadata as the initial
+		// but even though we use the value of initialMetadata as the initial
 		// value of the activeMetadata, we cannot put activeMetadata itself into
 		// the dependency array. If we did, we would destroy and rebuild each
 		// connection every single time a new message comes in from the socket,
 		// because the socket has to be wired up to the state setter
-		if (storybookMetadata !== undefined) {
+		if (initialMetadata !== undefined) {
 			return;
 		}
 
@@ -118,7 +118,7 @@ export const AgentMetadata: FC<AgentMetadataProps> = ({
 			window.clearTimeout(timeoutId);
 			activeSocket?.close();
 		};
-	}, [agent.id, storybookMetadata]);
+	}, [agent.id, initialMetadata]);
 
 	if (activeMetadata === undefined) {
 		return (

diff --git a/site/src/modules/resources/AgentRow.stories.tsx b/site/src/modules/resources/AgentRow.stories.tsx
@@ -1,4 +1,6 @@
 import type { Meta, StoryObj } from "@storybook/react";
+import { spyOn } from "@storybook/test";
+import { API } from "api/api";
 import { getPreferredProxy } from "contexts/ProxyContext";
 import { chromatic } from "testHelpers/chromatic";
 import * as M from "testHelpers/entities";
@@ -95,8 +97,7 @@ const meta: Meta<typeof AgentRow> = {
 			logs_length: logs.length,
 		},
 		workspace: M.MockWorkspace,
-		showApps: true,
-		storybookAgentMetadata: defaultAgentMetadata,
+		initialMetadata: defaultAgentMetadata,
 	},
 	decorators: [withProxyProvider(), withDashboardProvider, withWebSocket],
 	parameters: {
@@ -121,24 +122,6 @@ type Story = StoryObj<typeof AgentRow>;
 
 export const Example: Story = {};
 
-export const HideSSHButton: Story = {
-	args: {
-		hideSSHButton: true,
-	},
-};
-
-export const HideVSCodeDesktopButton: Story = {
-	args: {
-		hideVSCodeDesktopButton: true,
-	},
-};
-
-export const NotShowingApps: Story = {
-	args: {
-		showApps: false,
-	},
-};
-
 export const BunchOfApps: Story = {
 	args: {
 		agent: {
@@ -155,14 +138,13 @@ export const BunchOfApps: Story = {
 			],
 		},
 		workspace: M.MockWorkspace,
-		showApps: true,
 	},
 };
 
 export const Connecting: Story = {
 	args: {
 		agent: M.MockWorkspaceAgentConnecting,
-		storybookAgentMetadata: [],
+		initialMetadata: [],
 	},
 };
 
@@ -190,7 +172,7 @@ export const Started: Story = {
 export const StartedNoMetadata: Story = {
 	args: {
 		...Started.args,
-		storybookAgentMetadata: [],
+		initialMetadata: [],
 	},
 };
 
@@ -243,20 +225,30 @@ export const ShowingPortForward: Story = {
 };
 
 export const Outdated: Story = {
+	beforeEach: () => {
+    		spyOn(API, "getBuildInfo").mockResolvedValue({
+			...M.MockBuildInfo,
+			version: "v99.999.9999+c1cdf14",
+			agent_api_version: "1.0",
+		});
+	},
 	args: {
 		agent: M.MockWorkspaceAgentOutdated,
 		workspace: M.MockWorkspace,
-		serverVersion: "v99.999.9999+c1cdf14",
-		serverAPIVersion: "1.0",
 	},
 };
 
 export const Deprecated: Story = {
+	beforeEach: () => {
+		spyOn(API, "getBuildInfo").mockResolvedValue({
+			...M.MockBuildInfo,
+			version: "v99.999.9999+c1cdf14",
+			agent_api_version: "2.0",
+		});
+	},
 	args: {
 		agent: M.MockWorkspaceAgentDeprecated,
 		workspace: M.MockWorkspace,
-		serverVersion: "v99.999.9999+c1cdf14",
-		serverAPIVersion: "2.0",
 	},
 };
 

diff --git a/site/src/modules/resources/AgentRow.test.tsx b/site/src/modules/resources/AgentRow.test.tsx