8000 feat: add task page by BrunoQuaresma · Pull Request #18076 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add task page #18076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged

feat: add task page #18076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e365de
Add base structure
BrunoQuaresma May 28, 2025
3f28f89
Add task page
BrunoQuaresma May 28, 2025
d762c46
Apply PR review comments
BrunoQuaresma May 28, 2025
2e035f5
Use static icon instead of external
BrunoQuaresma May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply PR review comments
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 28, 2025
commit d762c463df9b6187b6f8704919dc75057e7fceef
6 changes: 3 additions & 3 deletions site/src/pages/TaskPage/TaskPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ export const Active: Story = {
apps: [
{
...MockWorkspaceApp,
id: "cloud-code",
display_name: "Cloud Code",
id: "claude-code",
display_name: "Claude Code",
icon: "https://uxwing.com/wp-content/themes/uxwing/download/brands-and-social-media/claude-ai-icon.png",
Copy link
Contributor
@hugodutka hugodutka May 28, 2025 8000 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't use externally hosted images.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this for many other storybook tests 😄 it has not been a problem so far

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using /icons/claude.svg

url: `${window.location.protocol}/iframe.html?viewMode=story&id=pages-terminal--ready&args=&globals=`,
external: true,
Expand Down Expand Up @@ -142,7 +142,7 @@ export const Active: Story = {
},
latest_app_status: {
...MockWorkspaceAppStatus,
app_id: "cloud-code",
app_id: "claude-code",
},
},
});
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/TerminalPage/TerminalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,8 @@ const TerminalPage: FC = () => {

let disposed = false;

// Open the web socket and hook it up to the terminal.
terminalWebsocketUrl(
// When on development mode we can bypass the proxy and connect directly.
process.env.NODE_ENV !== "development"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem does this change solve? Please add a comment if this wasn't committed by mistake.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment.

? proxy.preferredPathAppURL
: undefined,
Expand Down
Loading
0