fix(coderd): ensure agent timings are non-zero on insert #18065
Conversation
| ) | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
The issue referenced in #15432 originates from the codersdk.TimingStageConnect timing that's further down, but that one doesn't seem addressed?
The agent.FirstConnectedAt.Time is used unconditionally, but may be null. Do we have a way to represent this better?
We could always omit the entry, but personally I'd like to see it in the graph as an unterminated starting point, would give an indication we're waiting for something.
There was a problem hiding this comment.
We could represent both of these as codersdk.NullTime instead.
There was a problem hiding this comment.
It turns out the timings chart is built to render with a "loading" state until all of provisioner timings, script timings, and connection timings are populated with at least one value. The assumption here is that timings are only useful after a build has completed.
My previous change (#18058) adds a check in the UI so that causes a time range with a zero time to be rendered as an "instant" with an "Invalid" label.
I think that, for now, it makes sense to simply exclude the agent connection timing if !FirstConnectedAt.Valid. Does that sound alright?
There was a problem hiding this comment.
I'm fine with that if it can show up later if the agent finally connects 👍🏻
Relates to #15432
I checked in our dogfood database and couldn't find any instances of timings where
started_atorended_atwas the zero time. However it makes sense to me to ensure this can't ever happen.