8000 feat: create experimental template embed page for dynamic params by jaaydenh · Pull Request #17999 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: create experimental template embed page for dynamic params #17999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 23, 2025
Merged

feat: create experimental template embed page for dynamic params #17999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
78429ba
feat: update template embed page for dynamic params
jaaydenh Apr 27, 2025
ae7cf11
fix: fix types
jaaydenh Apr 27, 2025
e63b45c
fix: cleanup
jaaydenh May 22, 2025
793aaa2
chore: cleanup
jaaydenh May 22, 2025
a02e6df
fix: fix commits
jaaydenh May 22, 2025
62b54d5
chore: cleanup
jaaydenh May 22, 2025
1caf277
fix: remove usages of experimentalFormContext
jaaydenh Jun 20, 2025
a0505bb
feat: add shadcn skeleton
jaaydenh Jun 20, 2025
d9af4b2
fix: get things working correctly
jaaydenh Jun 20, 2025
e9671b9
feat: add a separator component
jaaydenh Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: add a separator component
  • Loading branch information
@jaaydenh
jaaydenh committed Jun 23, 2025
commit e9671b973a6ebfaa4394f4d5b196961c8d588a38
1 change: 1 addition & 0 deletions site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"@radix-ui/react-radio-group": "1.2.3",
"@radix-ui/react-scroll-area": "1.2.3",
"@radix-ui/react-select": "2.1.4",
"@radix-ui/react-separator": "1.1.7",
"@radix-ui/react-slider": "1.2.2",
"@radix-ui/react-slot": "1.1.1",
"@radix-ui/react-switch": "1.1.1",
Expand Down
78 changes: 78 additions & 0 deletions site/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 30 additions & 0 deletions site/src/components/Separator/Separator.tsx
View file
Open in desktop
FF64
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import * as SeparatorPrimitive from "@radix-ui/react-separator";
/**
* Copied from shadc/ui on 06/20/2025
* @see {@link https://ui.shadcn.com/docs/components/separator}
*/
import type * as React from "react";

import { cn } from "utils/cn";

function Separator({
className,
orientation = "horizontal",
decorative = true,
...props
}: React.ComponentProps<typeof SeparatorPrimitive.Root>) {
return (
<SeparatorPrimitive.Root
data-slot="separator"
decorative={decorative}
orientation={orientation}
className={cn(
"bg-border shrink-0 data-[orientation=horizontal]:h-px data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full data-[orientation=vertical]:w-px",
className,
)}
{...props}
/>
);
}

export { Separator };
3 changes: 3 additions & 0 deletions site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPageExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { ErrorAlert } from "components/Alert/ErrorAlert";
import { Button } from "components/Button/Button";
import { Label } from "components/Label/Label";
import { RadioGroup, RadioGroupItem } from "components/RadioGroup/RadioGroup";
import { Separator } from "components/Separator/Separator";
import { Skeleton } from "components/Skeleton/Skeleton";
import { useAuthenticated } from "hooks";
import { useEffectEvent } from "hooks/hookPolyfills";
Expand Down Expand Up @@ -244,6 +245,8 @@ const TemplateEmbedPageView: FC<TemplateEmbedPageViewProps> = ({
</RadioGroup>
</section>

<Separator />

{parameters.length > 0 && (
<div className="flex flex-col gap-9">
{parameters.map((parameter) => {
Expand Down
Loading
0