8000 feat: implement expiration policy logic for prebuilds by ssncferreira · Pull Request #17996 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat: implement expiration policy logic for prebuilds #17996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 26, 2025
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add preset_id to log messages in reconciliation cycle
  • Loading branch information
ssncferreira committed May 23, 2025
commit a904d3fc7c0ca3cee9d2b89355217e4188aeae7c
3 changes: 2 additions & 1 deletion enterprise/coderd/prebuilds/reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ func (c *StoreReconciler) ReconcilePreset(ctx context.Context, ps prebuilds.Pres
}

fields := []any{
slog.F("preset_id", ps.Preset.ID),
slog.F("desired", state.Desired), slog.F("actual", state.Actual),
slog.F("extraneous", state.Extraneous), slog.F("starting", state.Starting),
slog.F("stopping", state.Stopping), slog.F("deleting", state.Deleting),
Expand Down Expand Up @@ -543,7 +544,7 @@ func (c *StoreReconciler) executeReconciliationAction(ctx context.Context, logge
}

fields := []any{
slog.F("action_type", action.ActionType),
slog.F("preset_id", ps.Preset.ID), slog.F("action_type", action.ActionType),
slog.F("create_count", action.Create), slog.F("delete_count", len(action.DeleteIDs)),
slog.F("to_delete", action.DeleteIDs),
}
Expand Down
Loading
0