8000 chore: reduce `ignore_changes` suggestion scope by dannykopping · Pull Request #17947 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: reduce ignore_changes suggestion scope #17947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

chore: reduce ignore_changes suggestion scope #17947

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09743d5
chore: reduce ignore_changes suggestion scope
dannykopping May 20, 2025
de676fb
Update docs/admin/templates/extending-templates/prebuilt-workspaces.md
dannykopping May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions docs/admin/templates/extending-templates/prebuilt-workspaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ To prevent this, add a `lifecycle` block with `ignore_changes`:
```hcl
resource "docker_container" "workspace" {
lifecycle {
ignore_changes = all
ignore_changes = [env, image] # include all fields which caused drift
}

count = data.coder_workspace.me.start_count
Expand All @@ -151,19 +151,9 @@ resource "docker_container" "workspace" {
}
```

For more targeted control, specify which attributes to ignore:

```hcl
resource "docker_container" "workspace" {
lifecycle {
ignore_changes = [name]
}

count = data.coder_workspace.me.start_count
name = "coder-${data.coder_workspace_owner.me.name}-${lower(data.coder_workspace.me.name)}"
...
}
```
Try to keep `ignore_changes` scoped to just the fields which were called out in the notification. Excessive use of
`ignore_changes` can lead to undesirable outcomes in Terraform, like innocuous changes (which wouldn't cause replacements)
to be ignored.

Learn more about `ignore_changes` in the [Terraform documentation](https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle#ignore_changes).

Expand Down
Loading
0