chore: change approach

coder · DanielleMaywood · May 20, 2025 · May 20, 2025 · May 20, 2025 · May 20, 2025
commit 5fb0a5b7279a837da672479f494248b74d263a00
diff --git a/coderd/autobuild/lifecycle_executor.go b/coderd/autobuild/lifecycle_executor.go
@@ -349,13 +349,18 @@ func (e *Executor) runOnce(t time.Time) Stats {
 						nextBuildReason = string(nextBuild.Reason)
 					}
 
+					templateVersionMessage := activeTemplateVersion.Message
+					if templateVersionMessage == "" {
+						templateVersionMessage = "None provided"
+					}
+
 					if _, err := e.notificationsEnqueuer.Enqueue(e.ctx, ws.OwnerID, notifications.TemplateWorkspaceAutoUpdated,
 						map[string]string{
 							"name":                     ws.Name,
 							"initiator":                "autobuild",
 							"reason":                   nextBuildReason,
 							"template_version_name":    activeTemplateVersion.Name,
-							"template_version_message": activeTemplateVersion.Message,
+							"template_version_message": templateVersionMessage,
 						}, "autobuild",
 						// Associate this notification with all the related entities.
 						ws.ID, ws.OwnerID, ws.TemplateID, ws.OrganizationID,

diff --git a/coderd/database/migrations/000328_fix_workspace_update_reason.down.sql b/coderd/database/migrations/000328_fix_workspace_update_reason.down.sql
diff --git a/coderd/database/migrations/000328_fix_workspace_update_reason.up.sql b/coderd/database/migrations/000328_fix_workspace_update_reason.up.sql
diff --git a/coderd/notifications/notifications_test.go b/coderd/notifications/notifications_test.go
@@ -845,19 +845,6 @@ func TestNotificationTemplates_Golden(t *testing.T) {
 				},
 			},
 		},
-		{
-			name: "TemplateWorkspaceAutoUpdated_NoMessage",
-			id:   notifications.TemplateWorkspaceAutoUpdated,
-			payload: types.MessagePayload{
-				UserName:     "Bobby",
-				UserEmail:    "bobby@coder.com",
-				UserUsername: "bobby",
-				Labels: map[string]string{
-					"name":                  "bobby-workspace",
-					"template_version_name": "1.0",
-				},
-			},
-		},
 		{
 			name: "TemplateWorkspaceMarkedForDeletion",
 			id:   notifications.TemplateWorkspaceMarkedForDeletion,

diff --git a/...tions/testdata/rendered-templates/smtp/TemplateWorkspaceAutoUpdated_NoMessage.html.golden b/...tions/testdata/rendered-templates/smtp/TemplateWorkspaceAutoUpdated_NoMessage.html.golden
diff --git a/...ns/testdata/rendered-templates/webhook/TemplateWorkspaceAutoUpdated_NoMessage.json.golden b/...ns/testdata/rendered-templates/webhook/TemplateWorkspaceAutoUpdated_NoMessage.json.golden