fix: sync websocket params with form params #17895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
May 16, 2025
| @@ -136,7 +136,7 @@ const CreateWorkspacePageExperimental: FC = () => { | |||
| return; | |||
| } | |||
|
|
|||
| if (!initialParamsSentRef.current && response.parameters.length > 0) { | |||
| if (!initialParamsSentRef.current && response.parameters?.length > 0) { | |||
|
The default param value is sent on the form load. Then it all works from my brief testing. I am ok to merge this. @jaaydenh do you think we can make a unit test for this without the BE? Some set of mocked responses, and we come up with some table of behaviors together? |
Emyrk
approved these changes
May 19, 2025
Created coder/internal#650 to track tests for this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue is that when multiple parameters are added or removed from a form because a user change in a conditional parameter value. The websocket parameters response gets out of sync with the state of the parameters in the form.
The form state needs to be maintained because this is what gets submitted when the user attempts to create a workspace.
Fixes:
When autofill params are set from the url, mark these params as touched in the form. This is necessary as only touched params are sent in the request to the websocket. These params should technically count as being touched because they were preset from the url params.
Create a hook to synchronize the parameters from the websocket response with the current state of the parameters stored in the form.