feat: add Organization Provisioner Keys view #17889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Organization Provisioner Keys view feature to enable management of provisioner keys within the site. Key changes include:
- Exporting the MockProvisionerKey constant for test support.
- Adding lazy-loaded routes for the ProvisionerKeysPage in the router.
- Implementing view components, including a new table row component, page view, and corresponding Storybook stories.
- Updating API queries and sidebar navigation to integrate the new view.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/testHelpers/entities.ts | Exported MockProvisionerKey for broader test utility |
| site/src/router.tsx | Added lazy-loaded route and navigation entry for ProvisionerKeysPage |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/ProvisionerKeyRow.tsx | Introduced a new table row component for provisioner keys |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPageView.tsx | Implemented the view component for managing provisioner keys |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPageView.stories.tsx | Added Storybook stories for different page states |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPage.tsx | Created the page component, including data fetching and permission checks |
| site/src/modules/management/OrganizationSidebarView.tsx | Updated sidebar navigation to include the Provisioner Keys link |
| site/src/api/queries/organizations.ts | Exported provisionerDaemonGroups for use in the new page view |
...nizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPageView.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/ProvisionerKeyRow.tsx
Show resolved
Hide resolved
afcf7d0 to
6f9a9e9
Compare
|
You did a really nice work! I just would do some design changes, but I would need to play around with that in code. Is it ok for you? |
100% OK with me, thanks! |
mafredri
reviewed
May 19, 2025
| {showPaywall ? ( | ||
| <Paywall | ||
| message="Provisioners" | ||
| description="Provisioners run your Terraform to create templates and workspaces. You need a Premium license to use this feature for multiple organizations." |
There was a problem hiding this comment.
Not just multi-org right? Keys themselves require license too.
There was a problem hiding this comment.
This is a copy-paste of the existing paywall: https://github.com/coder/coder/blob/main/site/src/pages/OrganizationSettingsPage/OrganizationProvisionersPage/OrganizationProvisionersPageView.tsx#L100-L102
|
@johnstcn after my design changes: Screen.Recording.2025-05-19.at.11.57.31.mov
|
BrunoQuaresma
approved these changes
May 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17698
Demo:
Screen.Recording.2025-05-19.at.11.57.31.mov